From: Peter Wang <novalazy@gmail.com>
To: Mark Walters <markwalters1009@gmail.com>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH v7 03/12] cli: add insert command
Date: Sun, 23 Jun 2013 22:19:42 +1000 [thread overview]
Message-ID: <20130623221942.GA18938@hili.localdomain> (raw)
In-Reply-To: <8761x5uy3a.fsf@qmul.ac.uk>
On Sun, 23 Jun 2013 07:42:49 +0100, Mark Walters <markwalters1009@gmail.com> wrote:
>
> This is a +1 modulo one small bug (I think) I found below. I am happy to
> delay the fail-on-index-fail option, especially as that will need some
> bikeshedding on its name.
>
> Also when posting new versions please include a diff from the previous
> version (this is more difficult if there was significant rebasing). This
> makew the v6 to v7 change obvious (the one comment change and the
> bugfix).
>
> Moreover doing the diff with v4 (which I happen to have locally) I
> found the bug below.
>
> Best wishes
>
> Mark
>
>
>
...
> > +static notmuch_bool_t
> > +insert_message (void *ctx, notmuch_database_t *notmuch, int fdin,
> > + const char *dir, tag_op_list_t *tag_ops)
> > +{
> > + char *tmppath;
> > + char *newpath;
> > + char *newdir;
> > + int fdout;
> > + char *cleanup_path;
> > +
> > + fdout = maildir_open_tmp_file (ctx, dir, &tmppath, &newpath, &newdir);
> > + if (fdout < 0)
> > + return FALSE;
> > +
> > + cleanup_path = tmppath;
> > +
> > + if (! copy_stdin (fdin, fdout))
> > + goto FAIL;
> > +
> > + if (fsync (fdout) != 0) {
> > + fprintf (stderr, "Error: fsync failed: %s\n", strerror (errno));
> > + goto FAIL;
> > + }
> > +
> > + close (fdout);
> > + fdout = -1;
> > +
> > + /* Atomically move the new message file from the Maildir 'tmp' directory
> > + * to the 'new' directory. We follow the Dovecot recommendation to
> > + * simply use rename() instead of link() and unlink().
> > + * See also: http://wiki.dovecot.org/MailboxFormat/Maildir#Mail_delivery
> > + */
> > + if (rename (tmppath, newpath) != 0) {
> > + fprintf (stderr, "Error: rename() failed: %s\n", strerror (errno));
> > + goto FAIL;
> > + }
> > +
> > + if (! sync_dir (newdir))
> > + goto FAIL;
>
> I think cleanup_path needs to be updated before the sync_dir is test as
> newpath should be unlinked rather than oldpath. (v4 explicitly unlinked newpath)
>
Thanks for the continued close review.
I'll post a followup to this specific patch.
Peter
next prev parent reply other threads:[~2013-06-23 12:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-23 4:23 [PATCH v7 00/12] insert command Peter Wang
2013-06-23 4:23 ` [PATCH v7 01/12] tag-util: move out 'tag' command-line check Peter Wang
2013-06-23 4:23 ` [PATCH v7 02/12] tag-util: do not reset list in parse_tag_command_line Peter Wang
2013-06-23 4:23 ` [PATCH v7 03/12] cli: add insert command Peter Wang
2013-06-23 6:42 ` Mark Walters
2013-06-23 12:19 ` Peter Wang [this message]
2013-06-23 12:20 ` [PATCH v7b] " Peter Wang
2013-06-24 19:02 ` Mark Walters
2013-06-23 4:23 ` [PATCH v7 04/12] man: document 'insert' command Peter Wang
2013-06-23 4:23 ` [PATCH v7 05/12] man: reference notmuch-insert.1 Peter Wang
2013-06-23 4:23 ` [PATCH v7 06/12] test: add tests for insert Peter Wang
2013-06-30 14:44 ` David Bremner
2013-06-23 4:24 ` [PATCH v7 07/12] insert: add --folder option Peter Wang
2013-06-23 4:24 ` [PATCH v7 08/12] man: document insert " Peter Wang
2013-06-23 4:24 ` [PATCH v7 09/12] test: test " Peter Wang
2013-07-01 15:29 ` David Bremner
2013-06-23 4:24 ` [PATCH v7 10/12] insert: add --create-folder option Peter Wang
2013-06-23 4:24 ` [PATCH v7 11/12] man: document insert --create-folder Peter Wang
2013-06-23 4:24 ` [PATCH v7 12/12] test: test insert --create-folder option Peter Wang
2013-07-04 3:33 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130623221942.GA18938@hili.localdomain \
--to=novalazy@gmail.com \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).