From: Austin Clements <aclements@csail.mit.edu>
To: Mark Walters <markwalters1009@gmail.com>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH v4 0/5] emacs: show: lazy handling of hidden parts
Date: Sun, 9 Jun 2013 22:39:52 -0400 [thread overview]
Message-ID: <20130610023952.GC22196@mit.edu> (raw)
In-Reply-To: <1370074547-24677-1-git-send-email-markwalters1009@gmail.com>
Quoth Mark Walters on Jun 01 at 9:15 am:
> This is version 4 of this series. Version 3 is at
> id:1370024806-6616-1-git-send-email-markwalters1009@gmail.com
>
> Changes from version 3 are: fix the whitespace changes in patch 3/5,
> store both the start of the part and the start of the content in
> insert-bodypart (Austin's part handler series needs one and I need the
> other) and fixed the missing save-excursion in patch 4/5.
>
> Finally, there is one more substantial change: rebasing on to Austin's
> part handler (now in master). There was a little more to this than I
> expected so for anyone testing please use this version.
This series LGTM except for one bug (also related to my new part
handling, sorry): after expanding a lazy part, the "." submap doesn't
work within that part because it doesn't get the :notmuch-part
property applied to it. I'm not sure what the best solution to this
is. Maybe applying :notmuch-part should be moved to
notmuch-show-create-part-overlays?
Also, unrelated: with this series, do we wind up creating a second
overlay when a lazy part is shown?
prev parent reply other threads:[~2013-06-10 2:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-01 8:15 [PATCH v4 0/5] emacs: show: lazy handling of hidden parts Mark Walters
2013-06-01 8:15 ` [PATCH v4 1/5] emacs: show: fake wash parts are handled at insert-bodypart level Mark Walters
2013-06-01 8:15 ` [PATCH v4 2/5] emacs: show: move the insertion of the header button to the top level Mark Walters
2013-06-01 8:15 ` [PATCH v4 3/5] emacs: show: pass button to create-overlays Mark Walters
2013-06-01 8:15 ` [PATCH v4 4/5] emacs: show: modify the way hidden state is recorded Mark Walters
2013-06-01 8:15 ` [PATCH v4 5/5] emacs: show: implement lazy hidden part handling Mark Walters
2013-06-01 16:46 ` [PATCH v4 6/5] emacs: show: lazy-part bugfix Mark Walters
2013-06-10 2:39 ` Austin Clements [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130610023952.GC22196@mit.edu \
--to=aclements@csail.mit.edu \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).