From: Austin Clements <amdragon@MIT.EDU>
To: Mark Walters <markwalters1009@gmail.com>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] emacs: Fix "no such file or directory" error
Date: Sun, 9 Jun 2013 22:15:34 -0400 [thread overview]
Message-ID: <20130610021534.GB22196@mit.edu> (raw)
In-Reply-To: <87hah7od8b.fsf@qmul.ac.uk>
Quoth Mark Walters on Jun 09 at 10:16 am:
>
> Both of these patches look good to me +1. I was able to reproduce both
> bugs pretty reliably (the first one always unless masked by the second
> one which occurred about half the time). With these patches I cannot
> trigger either. Also all tests pass.
>
> My only tiny concern is I couldn't find any documentation on whether the
> return value of the filter-function matters at all. Austin's original
> fix (via irc) returned t and this returns nil in the failing case (i.e.,
> when results-buf is dead).
Mm, interesting. To be fair, my choice of "t" for the original fix
was completely arbitrary. I think you're right that the Emacs
documentation doesn't have anything to say about the return values of
filter functions. Furthermore, the example filter functions they give
don't have meaningful return values, so I'm pretty sure this is safe.
Also the code that calls the filter discards its result.
next prev parent reply other threads:[~2013-06-10 2:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-09 4:45 [PATCH 0/2] Fix errors when killing the search buffer Austin Clements
2013-06-09 4:45 ` [PATCH 1/2] emacs: Don't report CLI signals sent by Emacs as errors Austin Clements
2013-06-12 14:57 ` David Bremner
2013-06-09 4:45 ` [PATCH 2/2] emacs: Fix "no such file or directory" error Austin Clements
2013-06-09 9:16 ` Mark Walters
2013-06-10 2:15 ` Austin Clements [this message]
2013-06-10 6:21 ` Tomi Ollila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130610021534.GB22196@mit.edu \
--to=amdragon@mit.edu \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).