unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Austin Clements <amdragon@MIT.EDU>
To: david@tethera.net
Cc: notmuch@notmuchmail.org, David Bremner <bremner@debian.org>
Subject: Re: [PATCH] emacs: remove hardcoded defaults values from docstrings
Date: Tue, 4 Jun 2013 00:01:02 -0400	[thread overview]
Message-ID: <20130604040102.GJ5999@mit.edu> (raw)
In-Reply-To: <1370181885-23021-1-git-send-email-david@tethera.net>

I realize this already got pushed, but to me this seems like a
reversion for the 95% of users who haven't customized
notmuch-archive-tags and just want to know that archiving means
removing the inbox tag.  Why is this less confusing?  Users who have
customized notmuch-archive-tags will probably know that the "default"
doesn't apply to them.

Quoth david@tethera.net on Jun 02 at 11:04 am:
> From: David Bremner <bremner@debian.org>
> 
> These functions refer to default values of variables, but it seems
> less confusing and less likely to get out of date to just allow the
> user to follow the help cross-reference links.
> ---
>  emacs/notmuch-show.el | 14 ++++++--------
>  1 file changed, 6 insertions(+), 8 deletions(-)
> 
> another proposed change from our notmuch-pick discussions.
> 
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 613e666..600e802 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -1835,10 +1835,9 @@ search results instead."
>    "Archive each message in thread.
>  
>  Archive each message currently shown by applying the tag changes
> -in `notmuch-archive-tags' to each (remove the \"inbox\" tag by
> -default). If a prefix argument is given, the messages will be
> -\"unarchived\", i.e. the tag changes in `notmuch-archive-tags'
> -will be reversed.
> +in `notmuch-archive-tags' to each. If a prefix argument is given,
> +the messages will be \"unarchived\", i.e. the tag changes in
> +`notmuch-archive-tags' will be reversed.
>  
>  Note: This command is safe from any race condition of new messages
>  being delivered to the same thread. It does not archive the
> @@ -1865,10 +1864,9 @@ buffer."
>    "Archive the current message.
>  
>  Archive the current message by applying the tag changes in
> -`notmuch-archive-tags' to it (remove the \"inbox\" tag by
> -default). If a prefix argument is given, the message will be
> -\"unarchived\", i.e. the tag changes in `notmuch-archive-tags'
> -will be reversed."
> +`notmuch-archive-tags' to it. If a prefix argument is given, the
> +message will be \"unarchived\", i.e. the tag changes in
> +`notmuch-archive-tags' will be reversed."
>    (interactive "P")
>    (when notmuch-archive-tags
>      (apply 'notmuch-show-tag-message

  parent reply	other threads:[~2013-06-04  4:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-02 14:04 [PATCH] emacs: remove hardcoded defaults values from docstrings david
2013-06-02 14:29 ` [PATCH] emacs: add `notmuch-archive-tags' cross references in docstrings david
2013-06-02 14:32 ` [PATCH] emacs: remove hardcoded defaults values from docstrings Tomi Ollila
2013-06-02 17:47 ` Mark Walters
2013-06-03  0:03   ` David Bremner
2013-06-04  4:01 ` Austin Clements [this message]
2013-06-04  6:30   ` Tomi Ollila
2013-06-04 11:37     ` David Bremner
2013-06-04 13:37       ` Austin Clements
2013-06-04 14:22         ` David Bremner
2013-06-05  6:05           ` Tomi Ollila

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130604040102.GJ5999@mit.edu \
    --to=amdragon@mit.edu \
    --cc=bremner@debian.org \
    --cc=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).