From: Austin Clements <amdragon@MIT.EDU>
To: Tomi Ollila <tomi.ollila@iki.fi>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH 1/2] emacs: Add notmuch-combine-face-text-property-string
Date: Sun, 24 Mar 2013 22:15:51 -0400 [thread overview]
Message-ID: <20130325021551.GA32584@mit.edu> (raw)
In-Reply-To: <m2ppyq9wan.fsf@guru.guru-group.fi>
Quoth Tomi Ollila on Mar 23 at 1:42 pm:
> On Sat, Mar 23 2013, Damien Cassou <damien.cassou@gmail.com> wrote:
>
> > Signed-off-by: Damien Cassou <damien.cassou@gmail.com>
> > ---
>
> The function notmuch-combine-face-text-property-string is used only
> once in next patch. Do you anticipate more uses of it in the future?
It seems like a logical helper to notmuch-combine-face-text-property,
even if it's currently used in only one place.
> Tomi
>
> > emacs/notmuch-lib.el | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
> > index e6edb9a..78c578f 100644
> > --- a/emacs/notmuch-lib.el
> > +++ b/emacs/notmuch-lib.el
> > @@ -357,6 +357,14 @@ OBJECT."
> > (setq pos next))))
> > object)
> >
> > +(defun notmuch-combine-face-text-property-string (string face &optional below)
> > + (notmuch-combine-face-text-property
> > + 0
> > + (length string)
> > + face
> > + below
> > + string))
> > +
> > (defun notmuch-logged-error (msg &optional extra)
> > "Log MSG and EXTRA to *Notmuch errors* and signal MSG.
> >
> >
> > _______________________________________________
> > notmuch mailing list
> > notmuch@notmuchmail.org
> > http://notmuchmail.org/mailman/listinfo/notmuch
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2013-03-25 2:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-23 11:29 [PATCH v3 0/2] Customize how each tag is displayed Damien Cassou
2013-03-23 11:29 ` [PATCH 1/2] emacs: Add notmuch-combine-face-text-property-string Damien Cassou
2013-03-23 11:42 ` Tomi Ollila
2013-03-25 2:15 ` Austin Clements [this message]
2013-03-23 11:29 ` [PATCH 2/2] emacs: possibility to customize the rendering of tags Damien Cassou
2013-03-25 14:22 ` Austin Clements
2013-03-25 14:26 ` Austin Clements
2013-03-25 14:23 ` [PATCH v3 0/2] Customize how each tag is displayed Austin Clements
2013-03-25 15:46 ` David Bremner
2013-03-25 15:46 ` David Bremner
-- strict thread matches above, loose matches on Subject: below --
2013-02-06 14:53 [PATCH v2 " Damien Cassou
2013-02-06 14:53 ` [PATCH 1/2] emacs: Add notmuch-combine-face-text-property-string Damien Cassou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130325021551.GA32584@mit.edu \
--to=amdragon@mit.edu \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).