From: Austin Clements <amdragon@MIT.EDU>
To: Mark Walters <markwalters1009@gmail.com>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH v5 0/4] Use invisibility to toggle display of all parts including multipart
Date: Wed, 19 Dec 2012 00:11:13 -0500 [thread overview]
Message-ID: <20121219051113.GN6187@mit.edu> (raw)
In-Reply-To: <1355858880-16329-1-git-send-email-markwalters1009@gmail.com>
Quoth Mark Walters on Dec 18 at 7:27 pm:
> This is an alternative version of
> id:1355781287-6010-1-git-send-email-markwalters1009@gmail.com based on
> top of Austin's patch at
> id:1355812810-32747-1-git-send-email-amdragon@mit.edu
>
> Austin's patch significantly simplifies the invisibility handling
> taking this series down from 90/27 to 68/26 in diffstat terms.
>
> In general terms Austin's approach has to be the right thing to do:
> what we want to do just before the freeze is less clear. My view is
> that we should go with Austin's approach now so that at least any bugs
> we get from it and (more likely) from this series apply to master as
> well.
>
> I am posting this series to make it easier for people to judge the two
> approaches when finished (ie with part invisibility too).
>
> I attach a trimmed diff from v4 below the diffstat (note this was a
> diff with -U10 which I have trimmed so it is purely for information)
>
> Note we no longer need patch 4/5 because in this approach the overlays
> do not need to know about other overlays.
>
> Best wishes
>
> Mark
LGTM.
prev parent reply other threads:[~2012-12-19 5:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 19:27 [PATCH v5 0/4] Use invisibility to toggle display of all parts including multipart Mark Walters
2012-12-18 19:27 ` [PATCH v5 1/4] emacs: show: modify insert-part-header to save the button text Mark Walters
2012-12-21 14:10 ` David Bremner
2012-12-18 19:27 ` [PATCH v5 2/4] emacs: show: add overlays for each part Mark Walters
2012-12-18 19:27 ` [PATCH v5 3/4] emacs: show: add invisibility button action Mark Walters
2012-12-18 19:28 ` [PATCH v5 4/4] emacs: show: set default show-all-multipart/alternatives to nil Mark Walters
2012-12-19 5:11 ` Austin Clements [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121219051113.GN6187@mit.edu \
--to=amdragon@mit.edu \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).