From: Austin Clements <amdragon@MIT.EDU>
To: Peter Feigl <craven@gmx.net>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH 1/1] Changing build tool for test/random-corpus to CXX instead of CC.
Date: Tue, 4 Dec 2012 09:38:51 -0500 [thread overview]
Message-ID: <20121204143851.GJ1020@mit.edu> (raw)
In-Reply-To: <1354628820-2262-1-git-send-email-craven@gmx.net>
LGTM. I think we build the main notmuch binary with g++ for the same
reason.
Quoth Peter Feigl on Dec 04 at 2:47 pm:
> Without this change, GCC complains as follows:
> gcc test/random-corpus.o test/database-test.o notmuch-config.o command-line-arguments.o lib/libnotmuch.a util/libutil.a parse-time-string/libparse-time-string.a -o test/random-corpus -lgmime-2.6 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -Wl,-rpath,/usr/lib -ltalloc -lxapian
> /usr/bin/ld: lib/libnotmuch.a(database.o): undefined reference to symbol '_ZNSs4_Rep10_M_destroyERKSaIcE@@GLIBCXX_3.4'
> /usr/bin/ld: note: '_ZNSs4_Rep10_M_destroyERKSaIcE@@GLIBCXX_3.4' is defined in DSO /usr/lib/libstdc++.so.6 so try adding it to the linker command line
> /usr/lib/libstdc++.so.6: could not read symbols: Invalid operation
> collect2: error: ld returned 1 exit status
> make: *** [test/random-corpus] Error 1
> ---
> test/Makefile.local | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/Makefile.local b/test/Makefile.local
> index 6a9f15e..2ec6595 100644
> --- a/test/Makefile.local
> +++ b/test/Makefile.local
> @@ -22,7 +22,7 @@ random_corpus_deps = $(dir)/random-corpus.o $(dir)/database-test.o \
> parse-time-string/libparse-time-string.a
>
> $(dir)/random-corpus: $(random_corpus_deps)
> - $(call quiet,CC) $(CFLAGS_FINAL) $^ -o $@ $(CONFIGURE_LDFLAGS)
> + $(call quiet,CXX) $(CFLAGS_FINAL) $^ -o $@ $(CONFIGURE_LDFLAGS)
>
> $(dir)/smtp-dummy: $(smtp_dummy_modules)
> $(call quiet,CC) $^ -o $@
next prev parent reply other threads:[~2012-12-04 14:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-04 13:47 [PATCH 1/1] Changing build tool for test/random-corpus to CXX instead of CC Peter Feigl
2012-12-04 14:38 ` Austin Clements [this message]
2012-12-06 21:21 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121204143851.GJ1020@mit.edu \
--to=amdragon@mit.edu \
--cc=craven@gmx.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).