From: Austin Clements <amdragon@MIT.EDU>
To: Mark Walters <markwalters1009@gmail.com>
Cc: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/3] Adding an S-expression structured output printer.
Date: Sat, 1 Dec 2012 10:18:17 -0500 [thread overview]
Message-ID: <20121201151817.GF4681@mit.edu> (raw)
In-Reply-To: <87d2yu559y.fsf@qmul.ac.uk>
Quoth Mark Walters on Dec 01 at 12:24 pm:
>
> On Sat, 01 Dec 2012, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> > On Sat, Dec 01 2012, Mark Walters wrote:
> >
> >> Hi
> >>
> >> Overall I like the series: I think I agree with all of Jani's
> >> comments.
> >>
> >> My one extra comment is that I think we should decide on whether we also
> >> want a sexp plist version. I think we might want one for the emacs
> >> front-end as that currently uses plists for everything.
> >>
> >> If we do we might want to change the names a little, both for functions
> >> and options (eg sexp_a and sexp_p or something). Probably a lot of
> >> sprinter-sexp would be common to both versions.
> >
> > This is an important question that needs to be addressed fast: options
> > are:
> >
> > 1) have options to spit both alist & plist formats
> > 2) when converting emacs to use s-expressions, convert it to use alists
> > 3) start using plists instead of alists in Peter's android client
>
> Ok I have looked at this and the changes needed to output plist (or
> both) are pretty small: the only functions from sprinter-sexp.c that
> need to be changed are sexp_end and sexp_map_key. The total diff from
> alist to plist is about 10 lines. I have a version which allows both
> (the same sprinter file creates both possibilities) and have hooked it
> into emacs/notmuch-show.el and it all seems to work.
>
> (Search is more difficult as that uses the async parser; indeed even for
> show I used sexp-at-point as suggested by Tomi which seems rather
> underdocumented but does seem to work)
I'm happy to write an async sexp parser. I specifically designed the
async JSON parser with later switching to sexps in mind, so I already
have a plan for how to do this.
next prev parent reply other threads:[~2012-12-01 15:18 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-30 8:29 [PATCH 1/3] Adding an S-expression structured output printer Peter Feigl
2012-11-30 8:29 ` [PATCH 2/3] Use the S-Expression structured printer for notmuch search Peter Feigl
2012-11-30 18:04 ` Jani Nikula
2012-11-30 8:29 ` [PATCH 3/3] Use the S-Expression structured printer in notmuch show and notmuch reply Peter Feigl
2012-11-30 19:06 ` Jani Nikula
2012-11-30 8:34 ` [PATCH 1/3] Adding an S-expression structured output printer Peter Feigl
2012-11-30 17:26 ` Jani Nikula
2012-11-30 19:11 ` Jani Nikula
2012-12-01 9:59 ` Mark Walters
2012-12-01 11:34 ` Tomi Ollila
2012-12-01 12:24 ` Mark Walters
2012-12-01 13:29 ` Tomi Ollila
2012-12-01 13:45 ` Mark Walters
2012-12-01 14:26 ` Mark Walters
2012-12-01 15:46 ` Mark Walters
2012-12-01 15:18 ` Austin Clements [this message]
2012-12-01 16:14 ` Mark Walters
2012-12-04 14:46 ` [PATCH v2 0/5] New output format sexp (Lisp S-Expressions) Peter Feigl
2012-12-04 17:07 ` Jani Nikula
2012-12-06 7:33 ` [PATCH v3 " Peter Feigl
2012-12-06 8:22 ` Mark Walters
2012-12-07 2:54 ` Jameson Graef Rollins
2012-12-06 7:33 ` [PATCH v3 1/5] Adding an S-expression structured output printer Peter Feigl
2012-12-06 7:33 ` [PATCH v3 2/5] Rename the -json printer functions in notmuch-reply and notmuch-show to generic -sprinter functions Peter Feigl
2012-12-06 7:33 ` [PATCH v3 3/5] Use the S-Expression structured printer in notmuch-show, notmuch-reply and notmuch-search Peter Feigl
2012-12-06 7:33 ` [PATCH v3 4/5] Adding tests for --format=sexp Peter Feigl
2012-12-06 8:18 ` Mark Walters
2012-12-06 7:33 ` [PATCH v3 5/5] Updating man pages for new S-Expression output format Peter Feigl
2012-12-06 8:19 ` Mark Walters
2012-12-04 14:46 ` [PATCH v2 1/5] Adding an S-expression structured output printer Peter Feigl
2012-12-04 19:14 ` Austin Clements
2012-12-04 14:46 ` [PATCH v2 2/5] Rename the -json printer functions in notmuch-reply and notmuch-show to generic -sprinter functions Peter Feigl
2012-12-04 19:18 ` Austin Clements
2012-12-04 14:46 ` [PATCH v2 3/5] Use the S-Expression structured printer in notmuch-show, notmuch-reply and notmuch-search Peter Feigl
2012-12-04 19:22 ` Austin Clements
2012-12-04 14:46 ` [PATCH v2 4/5] Adding tests for --format=sexp Peter Feigl
2012-12-04 19:24 ` Austin Clements
2012-12-04 14:46 ` [PATCH v2 5/5] Updating man pages for new S-Expression output format Peter Feigl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121201151817.GF4681@mit.edu \
--to=amdragon@mit.edu \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).