From: Austin Clements <amdragon@MIT.EDU>
To: Mark Walters <markwalters1009@gmail.com>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH 0/6] API for iterating over all messages in a thread
Date: Sun, 25 Nov 2012 16:20:59 -0500 [thread overview]
Message-ID: <20121125212059.GN4562@mit.edu> (raw)
In-Reply-To: <87ehjhkb3a.fsf@qmul.ac.uk>
Quoth Mark Walters on Nov 25 at 2:31 pm:
>
> Hi
>
> This series looks good to me (I have not reviewed the two bindings
> patches). Patch 2 looks like it makes things much easier to follow than
> the current code (if I understood the current pointer stuff it
> constructs the top-level list by doing pointer stuff to remove all
> messages which are replies from the complete message list). Indeed, the
> diff is more complicated than the new code!
>
> On Sun, 25 Nov 2012, Austin Clements <amdragon@MIT.EDU> wrote:
> > This series adds a library API for iterating over all messages in a
> > thread in sorted order. This is easy for the library to provide and
> > difficult to obtain from the current API. Plus, if you don't count
> > the code added to the bindings, this series is actually a net
> > decrease of 4 lines of code because of simplifications it enables.
> >
> > Do we want the API to do more? Currently it's very minimal, but I can
> > imagine two ways it could be generalized. It could take an argument
> > to indicate which message list to return, which could be all messages,
> > matched messages, top-level messages, or maybe even unmatched messages
> > (possibly all in terms of message flags). It could also take an
> > argument indicating the desired sort order. Currently, the caller can
> > use existing message flag APIs to distinguish matched and unmatched
> > messages and there's a separate function for the top-level messages.
> > However, if the API could do all of these things, it would subsume
> > various other API functions, such as notmuch_thread_get_*_date.
>
> I don't know if this is the right API. For the matched message etc I
> think using the existing message flag APIs is simple enough. I am not
> sure about sort orders though: that looks like it would be much easier
> for the caller to have the correct sort by I am not sure what users
> would need it.
For sort order, I would be inclined to simply construct the reverse
list the first time a caller asks for it. Theoretically the caller
could do this just as easily as the library, except that we don't
expose the list routines.
If I do add sort order, I would also want to add some control over
which list is returned, since it would be asymmetric to be able to
request all messages in either order, but top-level messages only in
oldest-first. I think this would be pretty simple, and would give us
a reasonably general-purpose and extensible API. (It would also solve
the naming conundrum I mentioned below in my original email.)
> Best wishes
>
> Mark
>
>
>
>
> >
> > Also, is this the right name for the new API? In particular, if we do
> > later want to add a function that returns, say, the list of matched
> > messages, we'll have a convention collision with
> > notmuch_thread_get_matched_messages, which returns only a count.
next prev parent reply other threads:[~2012-11-25 21:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-25 4:57 [PATCH 0/6] API for iterating over all messages in a thread Austin Clements
2012-11-25 4:57 ` [PATCH 1/6] lib: Clean up error handling in _notmuch_thread_create Austin Clements
2013-02-19 1:13 ` David Bremner
2013-02-19 1:16 ` David Bremner
2012-11-25 4:57 ` [PATCH 2/6] lib: Separate list of all messages from top-level messages Austin Clements
2012-11-25 4:57 ` [PATCH 3/6] lib: Eliminate _notmuch_message_list_append Austin Clements
2012-11-25 4:57 ` [PATCH 4/6] lib: Add an iterator over all messages in a thread Austin Clements
2012-11-25 4:57 ` [PATCH 5/6] python: Add bindings for notmuch_thread_get_messages Austin Clements
2013-05-04 18:51 ` David Bremner
2013-05-05 17:00 ` David Bremner
2012-11-25 4:57 ` [PATCH 6/6] ruby: " Austin Clements
2012-11-26 16:23 ` Ali Polatel
2012-11-25 14:31 ` [PATCH 0/6] API for iterating over all messages in a thread Mark Walters
2012-11-25 21:20 ` Austin Clements [this message]
2012-11-26 17:19 ` Tomi Ollila
2012-11-26 17:35 ` Austin Clements
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121125212059.GN4562@mit.edu \
--to=amdragon@mit.edu \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).