From: Austin Clements <amdragon@MIT.EDU>
To: Jani Nikula <jani@nikula.org>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH v6 0/9] notmuch search date:since..until query support
Date: Tue, 30 Oct 2012 23:17:25 -0400 [thread overview]
Message-ID: <20121031031725.GL15377@mit.edu> (raw)
In-Reply-To: <cover.1351626272.git.jani@nikula.org>
LGTM.
Quoth Jani Nikula on Oct 30 at 10:32 pm:
> Hi all, v6 of [1] with plenty of small changes addressing Austin's
> review [2], [3], [4], and [5]. See my replies to Austin for what I've
> agreed to change, and what I've chosen to ignore and why.
>
> The single biggest change is the requirement to have some delimiter(s)
> between keywords, which allowed simplification of keyword
> matching. Consequently match_keyword() and parse_keyword() functions in
> patch 2/9 have changed considerably.
>
> There are a few ways to examine the changes since v5. My public repo at
> [6] has branches topic-parse-time-string-v5 (rebased to master) and
> topic-parse-time-string-v6, and [7] should provide a fancy colorful diff
> between the two. The same but less fancy diff is also at the end of this
> cover letter.
>
> Change by change commits to the parser and test tool can also be found
> at [8]. The source files there are copied verbatim to patches 2/9 and
> 3/9.
next prev parent reply other threads:[~2012-10-31 3:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 20:32 [PATCH v6 0/9] notmuch search date:since..until query support Jani Nikula
2012-10-30 20:32 ` [PATCH v6 1/9] build: drop the -Wswitch-enum warning Jani Nikula
2012-10-30 20:32 ` [PATCH v6 2/9] parse-time-string: add a date/time parser to notmuch Jani Nikula
2012-10-30 20:32 ` [PATCH v6 3/9] test: add new test tool parse-time for date/time parser Jani Nikula
2012-10-30 20:32 ` [PATCH v6 4/9] test: add smoke tests for the date/time parser module Jani Nikula
2012-10-30 20:32 ` [PATCH v6 5/9] build: build parse-time-string as part of the notmuch lib and static cli Jani Nikula
2012-10-30 20:32 ` [PATCH v6 6/9] lib: add date range query support Jani Nikula
2012-10-30 20:32 ` [PATCH v6 7/9] test: add tests for date:since..until range queries Jani Nikula
2012-10-30 20:32 ` [PATCH v6 8/9] man: document the " Jani Nikula
2012-10-30 20:32 ` [PATCH v6 9/9] NEWS: date range search support Jani Nikula
2012-10-31 3:17 ` Austin Clements [this message]
2012-10-31 11:35 ` [PATCH v6 0/9] notmuch search date:since..until query support Tomi Ollila
2012-10-31 20:21 ` David Bremner
2012-11-02 17:40 ` Michal Sojka
2012-11-02 18:53 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121031031725.GL15377@mit.edu \
--to=amdragon@mit.edu \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).