unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Austin Clements <amdragon@MIT.EDU>
To: Jameson Graef Rollins <jrollins@finestructure.net>
Cc: Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH 05/11] lib: add ability to store recipients in message structure
Date: Sat, 8 Sep 2012 13:24:31 -0400	[thread overview]
Message-ID: <20120908172431.GA22240@mit.edu> (raw)
In-Reply-To: <1345427570-26518-6-git-send-email-jrollins@finestructure.net>

Quoth Jameson Graef Rollins on Aug 19 at  6:52 pm:
> Added as a string, in parallel to the authors element.
> ---
>  lib/message.cc        |   18 ++++++++++++++++++
>  lib/notmuch-private.h |    9 +++++++++
>  2 files changed, 27 insertions(+)
> 
> diff --git a/lib/message.cc b/lib/message.cc
> index 978de06..fa28073 100644
> --- a/lib/message.cc
> +++ b/lib/message.cc
> @@ -36,6 +36,7 @@ struct visible _notmuch_message {
>      notmuch_string_list_t *filename_term_list;
>      notmuch_string_list_t *filename_list;
>      char *author;
> +    char *recipients;
>      notmuch_message_file_t *message_file;
>      notmuch_message_list_t *replies;
>      unsigned long flags;
> @@ -109,6 +110,7 @@ _notmuch_message_create_for_document (const void *talloc_owner,
>      message->filename_list = NULL;
>      message->message_file = NULL;
>      message->author = NULL;
> +    message->recipients = NULL;
>  
>      message->replies = _notmuch_message_list_create (message);
>      if (unlikely (message->replies == NULL)) {
> @@ -808,6 +810,22 @@ notmuch_message_set_author (notmuch_message_t *message,
>      return;
>  }
>  
> +const char *
> +notmuch_message_get_recipients (notmuch_message_t *message)
> +{
> +    return message->recipients;
> +}
> +
> +void
> +notmuch_message_set_recipients (notmuch_message_t *message,
> +				const char *recipients)
> +{
> +    if (message->recipients)
> +	talloc_free(message->recipients);
> +    message->recipients = talloc_strdup(message, recipients);

Missing spaces before parameter lists.

> +    return;
> +}
> +
>  void
>  _notmuch_message_set_header_values (notmuch_message_t *message,
>  				    const char *date,
> diff --git a/lib/notmuch-private.h b/lib/notmuch-private.h
> index bfb4111..27a41b6 100644
> --- a/lib/notmuch-private.h
> +++ b/lib/notmuch-private.h
> @@ -325,6 +325,15 @@ notmuch_message_set_author (notmuch_message_t *message, const char *author);
>  const char *
>  notmuch_message_get_author (notmuch_message_t *message);
>  
> +/* Set the recipients of 'message' - this is the representation used
> + * when displaying the message */
> +void
> +notmuch_message_set_recipients (notmuch_message_t *message, const char *recipients);
> +
> +/* Get the authors of 'message' */
> +const char *
> +notmuch_message_get_recipients (notmuch_message_t *message);
> +
>  
>  /* index.cc */
>  

-- 
Austin Clements                                      MIT/'06/PhD/CSAIL
amdragon@mit.edu                           http://web.mit.edu/amdragon
       Somewhere in the dream we call reality you will find me,
              searching for the reality we call dreams.

  parent reply	other threads:[~2012-09-08 17:24 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-20  1:52 [PATCH 00/11] add recipients to search output Jameson Graef Rollins
2012-08-20  1:52 ` [PATCH 01/11] lib: new thread addresses structure Jameson Graef Rollins
2012-08-20  1:52   ` [PATCH 02/11] lib: use new addresses structure for thread authors Jameson Graef Rollins
2012-08-20  1:52     ` [PATCH 03/11] lib: give _thread_cleanup_author a more generic name Jameson Graef Rollins
2012-08-20  1:52       ` [PATCH 04/11] lib: remove no longer needed author-specific thread functions Jameson Graef Rollins
2012-08-20  1:52         ` [PATCH 05/11] lib: add ability to store recipients in message structure Jameson Graef Rollins
2012-08-20  1:52           ` [PATCH 06/11] lib: store thread recipients in thread structure Jameson Graef Rollins
2012-08-20  1:52             ` [PATCH 07/11] test: search recipient output Jameson Graef Rollins
2012-08-20  1:52               ` [PATCH 08/11] cli: add thread recipients to search output Jameson Graef Rollins
2012-08-20  1:52                 ` [PATCH 09/11] emacs: add ability to show recipients instead of author in search Jameson Graef Rollins
2012-08-20  1:52                   ` [PATCH 10/11] emacs: add function to toggle showing authors/recipients " Jameson Graef Rollins
2012-08-20  1:52                     ` [PATCH 11/11] lib: add recipients to database Jameson Graef Rollins
2012-08-31 21:34                       ` Michal Sojka
2012-08-31 21:00                 ` [PATCH 08/11] cli: add thread recipients to search output Michal Sojka
2012-08-31 20:44             ` [PATCH 06/11] lib: store thread recipients in thread structure Michal Sojka
2012-09-02  7:52             ` Mark Walters
2012-09-08 17:25             ` Austin Clements
2012-08-31 20:19           ` [PATCH 05/11] lib: add ability to store recipients in message structure Michal Sojka
2012-09-08 17:24           ` Austin Clements [this message]
2012-09-08 17:25       ` [PATCH 03/11] lib: give _thread_cleanup_author a more generic name Austin Clements
2012-09-08 17:24     ` [PATCH 02/11] lib: use new addresses structure for thread authors Austin Clements
2012-08-30 15:38   ` [PATCH 01/11] lib: new thread addresses structure Michal Sojka
2012-08-30 16:33     ` Jameson Graef Rollins
2012-09-08 17:24   ` Austin Clements
2012-08-22 20:43 ` [PATCH 00/11] add recipients to search output Jameson Graef Rollins
2012-08-23  7:21 ` Tomi Ollila
2012-09-08 17:23 ` Austin Clements

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120908172431.GA22240@mit.edu \
    --to=amdragon@mit.edu \
    --cc=jrollins@finestructure.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).