Re: [PATCH] emacs: Fix "not defined at runtime" warning

[Austin Clements <amdragon@MIT.EDU>]

Quoth Jameson Graef Rollins on Aug 09 at 12:54 am:
> On Wed, Aug 08 2012, Austin Clements <amdragon@MIT.EDU> wrote:
> > Previously, the Emacs byte compiler produced the warning
> >
> >     the function `remove-if-not' might not be defined at runtime.
> >
> > because we only required cl at compile-time (not runtime).  This fixes
> > this warning by requiring cl at runtime, ensuring that the definition
> > of remove-if-not is available.
> > ---
> >  emacs/notmuch-lib.el |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
> > index 30db58f..900235b 100644
> > --- a/emacs/notmuch-lib.el
> > +++ b/emacs/notmuch-lib.el
> > @@ -24,7 +24,7 @@
> >  (require 'mm-view)
> >  (require 'mm-decode)
> >  (require 'json)
> > -(eval-when-compile (require 'cl))
> > +(require 'cl)
> >  
> >  (defvar notmuch-command "notmuch"
> >    "Command to run the notmuch binary.")
> 
> LGTM.  I think it would be good to finally just give in a require cl, so
> we can finally put to rest the long standing schizophrenia we've had in
> regards to using it, and maybe finally kill the compile warnings that
> keep popping up.

I think we already gave in [0], we just weren't very thorough about
it.

[0] id:"m262g864dz.fsf@wal122.wireless-pennnet.upenn.edu"