From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 74FCB431FAF for ; Wed, 18 Jul 2012 13:41:54 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PQw-ulI-ggWT for ; Wed, 18 Jul 2012 13:41:54 -0700 (PDT) Received: from dmz-mailsec-scanner-4.mit.edu (DMZ-MAILSEC-SCANNER-4.MIT.EDU [18.9.25.15]) by olra.theworths.org (Postfix) with ESMTP id 06A29431FAE for ; Wed, 18 Jul 2012 13:41:53 -0700 (PDT) X-AuditID: 1209190f-b7f306d0000008b4-53-50071f91bfde Received: from mailhub-auth-3.mit.edu ( [18.9.21.43]) by dmz-mailsec-scanner-4.mit.edu (Symantec Messaging Gateway) with SMTP id AC.9A.02228.19F17005; Wed, 18 Jul 2012 16:41:53 -0400 (EDT) Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id q6IKfrJC023535; Wed, 18 Jul 2012 16:41:53 -0400 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) (authenticated bits=0) (User authenticated as amdragon@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q6IKfqQo003472 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Wed, 18 Jul 2012 16:41:53 -0400 (EDT) Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) (envelope-from ) id 1Srb4C-0001DI-3g; Wed, 18 Jul 2012 16:41:52 -0400 Date: Wed, 18 Jul 2012 16:41:52 -0400 From: Austin Clements To: Adrien Bustany Subject: Re: [PATCH 5/7] go: Partially bind notmuch_database_upgrade Message-ID: <20120718204152.GU31670@mit.edu> References: <1342636475-16057-1-git-send-email-adrien@bustany.org> <1342636475-16057-6-git-send-email-adrien@bustany.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1342636475-16057-6-git-send-email-adrien@bustany.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpmleLIzCtJLcpLzFFi42IR4hTV1p0ozx5gcOCQtsX6O2vZLK7fnMns wOTx8cA9Jo9nq24xBzBFcdmkpOZklqUW6dslcGXM3/OQtWAZZ8WJxpAGxsPsXYycHBICJhKP Tp5ng7DFJC7cWw9kc3EICexjlDh8/y4ThLOBUaLlTwMrhHOSSeLK7RaosiWMEi8aesBmsQio Slw4dgNsFpuAhsS2/csZQWwRAXWJHZ3tYDazgLTEt9/NTCC2sICLxP3m52A2r4COxINp+1lB bCGBaonDPS1sEHFBiZMzn7BA9GpJ3Pj3EqieA2zO8n8cIGFOAWeJzce+MIPYogIqElNObmOb wCg0C0n3LCTdsxC6FzAyr2KUTcmt0s1NzMwpTk3WLU5OzMtLLdI10cvNLNFLTSndxAgOa0n+ HYzfDiodYhTgYFTi4X2wizVAiDWxrLgy9xCjJAeTkijvJyH2ACG+pPyUyozE4oz4otKc1OJD jBIczEoivA8EgXK8KYmVValF+TApaQ4WJXHeqyk3/YUE0hNLUrNTUwtSi2CyMhwcShK8u+WA GgWLUtNTK9Iyc0oQ0kwcnCDDeYCGF4PU8BYXJOYWZ6ZD5E8xKkqJ814DSQiAJDJK8+B6YWnn FaM40CvCvBtAqniAKQuu+xXQYCagwdzFbCCDSxIRUlINjIxWCs2z/+68/dIkwa3hvCn/Sd17 zOcTX/swZTit0lhven3dk02fA4zsDb6YbTzR7R4Vs6FNwdv5y/JOoyJj0a9tHm9tZ/n4WNo7 XTC49+33/4UyhdxvFadt/H5l8kY2VunD2cx9N15z5R0qlu2yZmVU65mvuTH6b8eSMxeXF65c xfnk9vptxUosxRmJhlrMRcWJAEgQkJIWAwAA Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jul 2012 20:41:54 -0000 Quoth Adrien Bustany on Jul 18 at 9:34 pm: > This binding does not handle the progress callback, but at least allows > opening and upgrading a database if needed. > --- > bindings/go/src/notmuch/notmuch.go | 13 ++++++++++++- > 1 files changed, 12 insertions(+), 1 deletions(-) > > diff --git a/bindings/go/src/notmuch/notmuch.go b/bindings/go/src/notmuch/notmuch.go > index d8b2739..384d5a5 100644 > --- a/bindings/go/src/notmuch/notmuch.go > +++ b/bindings/go/src/notmuch/notmuch.go > @@ -296,7 +296,18 @@ func (self *Database) NeedsUpgrade() bool { > return true > } > > -// TODO: notmuch_database_upgrade > +// TODO: Proper notmuch_database_upgrade > +/* Upgrade the current database. > + * > + * After opening a database in read-write mode, the client should > + * check if an upgrade is needed (notmuch_database_needs_upgrade) and > + * if so, upgrade with this function before making any modifications. > + */ > +func (self *Database) Upgrade() Status { > + st := Status(C.notmuch_database_upgrade(self.db, nil, nil)); > + > + return st; *gasp* Semicolons! > +} > > /* Retrieve a directory object from the database for 'path'. > *