From: Peter Wang <novalazy@gmail.com>
To: Mark Walters <markwalters1009@gmail.com>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH 4/8] man: clarify search --exclude documentation
Date: Sat, 23 Jun 2012 12:02:44 +1000 [thread overview]
Message-ID: <20120623120244.GB2330@hili.localdomain> (raw)
In-Reply-To: <87ehp93fx6.fsf@qmul.ac.uk>
On Wed, 20 Jun 2012 21:08:05 +0100, Mark Walters <markwalters1009@gmail.com> wrote:
>
> I have reviewed all the new parts of this series (judged as being
> patches 3-8) and the changes made to my two patches and they are all
> fine (with one small comment below). Patch 1/8 does need a proper review
> though as it ended up more intrusive than I would have liked.
>
> > +Messages matching search.tag_exclude are called "excluded messages".
>
> My one comment is that this is not quite true if the corresponding tag
> is in the query. Since you are defining the term it would be nice to
> mention that, but I can't see a clean wording.
How about:
A message is called "excluded" if it matches at least one tag
in search.tag_exclude that does not appear explicitly in the search
terms.
Or less densely:
Let "excluded tags" be the set of tags listed in search.tag_exclude,
minus any tags which appear explicitly in the search terms.
A message is an "excluded message" if it matches one or more
excluded tags.
Peter
next prev parent reply other threads:[~2012-06-23 2:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-20 13:28 [PATCH 0/8] search --exclude=all Peter Wang
2012-06-20 13:29 ` [PATCH 1/8] lib: add --exclude=all option Peter Wang
2013-05-11 18:07 ` David Bremner
2012-06-20 13:29 ` [PATCH 2/8] cli: add --exclude=all option to notmuch-search.c Peter Wang
2012-06-20 13:29 ` [PATCH 3/8] test: add tests for search --exclude=all Peter Wang
2012-06-20 13:29 ` [PATCH 4/8] man: clarify search --exclude documentation Peter Wang
2012-06-20 20:08 ` Mark Walters
2012-06-23 2:02 ` Peter Wang [this message]
2012-06-23 7:14 ` Mark Walters
2012-06-20 13:29 ` [PATCH 5/8] man: clarify search --exclude=flag Peter Wang
2012-06-20 13:29 ` [PATCH 6/8] man: document search --exclude=all Peter Wang
2012-06-20 13:29 ` [PATCH 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t Peter Wang
2012-10-19 5:15 ` Ethan Glasser-Camp
2012-10-19 21:23 ` Ethan Glasser-Camp
2012-10-20 10:04 ` Tomi Ollila
2012-10-21 2:04 ` Peter Wang
2012-10-21 12:10 ` Tomi Ollila
2012-10-21 13:03 ` Ethan Glasser-Camp
2012-06-20 13:29 ` [PATCH 8/8] cli: use notmuch_exclude_t in option parser Peter Wang
2012-07-22 1:18 ` [PATCH v2 4/8] man: clarify search --exclude documentation Peter Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120623120244.GB2330@hili.localdomain \
--to=novalazy@gmail.com \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).