From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id B56FF431FBC for ; Fri, 25 May 2012 07:44:06 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GJnmCLKTejrU for ; Fri, 25 May 2012 07:44:06 -0700 (PDT) Received: from dmz-mailsec-scanner-8.mit.edu (DMZ-MAILSEC-SCANNER-8.MIT.EDU [18.7.68.37]) by olra.theworths.org (Postfix) with ESMTP id 462B3431FB6 for ; Fri, 25 May 2012 07:44:06 -0700 (PDT) X-AuditID: 12074425-b7f966d0000008b6-ff-4fbf9ab52f5f Received: from mailhub-auth-4.mit.edu ( [18.7.62.39]) by dmz-mailsec-scanner-8.mit.edu (Symantec Messaging Gateway) with SMTP id 9D.D5.02230.5BA9FBF4; Fri, 25 May 2012 10:44:05 -0400 (EDT) Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id q4PEi56u015057; Fri, 25 May 2012 10:44:05 -0400 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) (authenticated bits=0) (User authenticated as amdragon@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q4PEi3ZS007933 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Fri, 25 May 2012 10:44:04 -0400 (EDT) Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) (envelope-from ) id 1SXvkJ-0000dw-Ol; Fri, 25 May 2012 10:44:03 -0400 Date: Fri, 25 May 2012 10:44:03 -0400 From: Austin Clements To: Jameson Graef Rollins Subject: Re: [PATCH v4 0/7] cli: improved crypto internals Message-ID: <20120525144403.GD11804@mit.edu> References: <1337812843-14986-1-git-send-email-jrollins@finestructure.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1337812843-14986-1-git-send-email-jrollins@finestructure.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpileLIzCtJLcpLzFFi42IRYrdT1906a7+/Qd9uY4s9+7wsrt+cyezA 5HH3NJfHs1W3mAOYorhsUlJzMstSi/TtErgyfv5Zz1RwkKXiw8FvzA2MJ5i7GDk5JARMJPa/ P8YOYYtJXLi3nq2LkYtDSGAfo8T0pzeZIJwNjBKz17awQzgnmSQ2H1rPCuEsYZQ419HMCNLP IqAq8enYQTCbTUBDYtv+5WC2iICZRM+XP2A2s4CWxNaNH8BsYQEricWrpjCB2LwCOhJ/j00E u0lIwEti2uEjbBBxQYmTM5+wwPTe+PcSqJ4DyJaWWP6PAyTMKeAt8e9LH9gYUQEViSknt7FN YBSahaR7FpLuWQjdCxiZVzHKpuRW6eYmZuYUpybrFicn5uWlFula6OVmluilppRuYgQHtYvq DsYJh5QOMQpwMCrx8DJF7/MXYk0sK67MPcQoycGkJMp7ZuZ+fyG+pPyUyozE4oz4otKc1OJD jBIczEoivCxpQDnelMTKqtSifJiUNAeLkjjvOs3d/kIC6YklqdmpqQWpRTBZGQ4OJQleHmD0 CgkWpaanVqRl5pQgpJk4OEGG8wANvwiymLe4IDG3ODMdIn+KUVFKnPcySEIAJJFRmgfXC0s6 rxjFgV4R5p0JUsUDTFhw3a+ABjMBDd7yeC/I4JJEhJRUA6OISNlzbXaLf4KsZ7RvaCbPP2/O 7Lj9x9V7gbu8gkpCf82ZUN53RDrF+p9PlezelxGuORnZwhk+1y+87+veuvwV38eX9hNnfnZW zv7yY8Ify0v3QpKvRW3PzDpy0PeOnvYTo1ubdGsnet3pyOG2NCzWe9b582pmc2xz8LS+RXWO rT3tLiu2uyqxFGckGmoxFxUnAgA7Jc6vFQMAAA== Cc: Notmuch Mail X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 May 2012 14:44:06 -0000 Quoth Jameson Graef Rollins on May 23 at 3:40 pm: > Ok, hopefully last version. This addresses Jani's latest comments. > > The first patch uses a typedef to handle the incompatibility between > the crypto context between GMIME 2.4 and 2.6. We probably should have > done this originally, as it gets rid of a bunch of #ifdefs, and should > help reduce confusion. > > I also move to use strcasecmp for the crypto protocol, with a comment > that points to the relevant RFCs for justification. This series LGTM other than the one and a half comments I just sent.