From: Austin Clements <amdragon@MIT.EDU>
To: Jameson Graef Rollins <jrollins@finestructure.net>
Cc: Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH v4 0/7] cli: improved crypto internals
Date: Fri, 25 May 2012 10:44:03 -0400 [thread overview]
Message-ID: <20120525144403.GD11804@mit.edu> (raw)
In-Reply-To: <1337812843-14986-1-git-send-email-jrollins@finestructure.net>
Quoth Jameson Graef Rollins on May 23 at 3:40 pm:
> Ok, hopefully last version. This addresses Jani's latest comments.
>
> The first patch uses a typedef to handle the incompatibility between
> the crypto context between GMIME 2.4 and 2.6. We probably should have
> done this originally, as it gets rid of a bunch of #ifdefs, and should
> help reduce confusion.
>
> I also move to use strcasecmp for the crypto protocol, with a comment
> that points to the relevant RFCs for justification.
This series LGTM other than the one and a half comments I just sent.
prev parent reply other threads:[~2012-05-25 14:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-23 22:40 [PATCH v4 0/7] cli: improved crypto internals Jameson Graef Rollins
2012-05-23 22:40 ` [PATCH v4 1/7] cli: use typedef to deal with gmime 2.4/2.6 incompatibility Jameson Graef Rollins
2012-05-23 22:40 ` [PATCH v4 2/7] cli: new crypto structure to store crypto contexts and parameters, and functions to support it Jameson Graef Rollins
2012-05-23 22:40 ` [PATCH v4 3/7] cli: modify show and reply to use new crypto struct Jameson Graef Rollins
2012-05-23 22:40 ` [PATCH v4 4/7] cli: modify mime_node_open to take new crypto struct as argument Jameson Graef Rollins
2012-05-23 22:40 ` [PATCH v4 5/7] cli: modify mime_node_context to use the new crypto struct Jameson Graef Rollins
2012-05-23 22:40 ` [PATCH v4 6/7] cli: new crypto verify flag to handle verification Jameson Graef Rollins
2012-05-23 22:40 ` [PATCH v4 7/7] cli: use new notmuch_crypto_get_context in mime-node.c Jameson Graef Rollins
2012-05-25 14:42 ` [PATCH v4 2/7] cli: new crypto structure to store crypto contexts and parameters, and functions to support it Austin Clements
2012-05-25 14:41 ` [PATCH v4 1/7] cli: use typedef to deal with gmime 2.4/2.6 incompatibility Austin Clements
2012-05-25 15:47 ` Jameson Graef Rollins
2012-05-25 16:23 ` Austin Clements
2012-05-25 18:14 ` Tomi Ollila
2012-05-25 13:15 ` [PATCH v4 0/7] cli: improved crypto internals Jani Nikula
2012-05-25 15:48 ` Jameson Graef Rollins
2012-05-25 14:44 ` Austin Clements [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120525144403.GD11804@mit.edu \
--to=amdragon@mit.edu \
--cc=jrollins@finestructure.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).