From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 4D2AC431FD0 for ; Wed, 23 May 2012 03:29:56 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Jd8zvFEJBB4T for ; Wed, 23 May 2012 03:29:55 -0700 (PDT) Received: from mail.cryptobitch.de (cryptobitch.de [88.198.7.68]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id B34FC431FAF for ; Wed, 23 May 2012 03:29:55 -0700 (PDT) Received: from mail.jade-hamburg.de (mail.jade-hamburg.de [85.183.11.228]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.cryptobitch.de (Postfix) with ESMTPSA id 24F1551150C for ; Wed, 23 May 2012 12:29:54 +0200 (CEST) Received: by mail.jade-hamburg.de (Postfix, from userid 401) id 88BF3DF2A3; Wed, 23 May 2012 12:29:53 +0200 (CEST) Received: from thinkbox.jade-hamburg.de (thinkbox.jadE-Hamburg.de [10.1.1.153]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: teythoon) by mail.jade-hamburg.de (Postfix) with ESMTPSA id A1E3ADF2A0; Wed, 23 May 2012 12:29:52 +0200 (CEST) Received: from teythoon by thinkbox.jade-hamburg.de with local (Exim 4.77) (envelope-from ) id 1SX8oC-0007TA-Up; Wed, 23 May 2012 12:28:48 +0200 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Justus Winter <4winter@informatik.uni-hamburg.de> User-Agent: alot/0.3+ To: Austin Clements , notmuch@notmuchmail.org References: <1337314423-3702-1-git-send-email-amdragon@mit.edu> In-Reply-To: <1337314423-3702-1-git-send-email-amdragon@mit.edu> Message-ID: <20120523102848.10967.53020@thinkbox.jade-hamburg.de> Subject: Re: [PATCH 0/9] Fix directory lookup on read-only databases Date: Wed, 23 May 2012 12:28:48 +0200 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 May 2012 10:29:56 -0000 Hi Austin :) Quoting Austin Clements (2012-05-18 06:13:33) > This fixes notmuch_database_get_directory and > notmuch_database_find_message_by_filename so that they don't attempt > to create missing directory documents. This makes them work on > read-only databases (and prevents n_d_f_m_b_f from crashing > unceremoniously on read-only databases). Thanks for taking care of this, this patch series looks good. > If we do a 0.13.1 bug fix release, these patches could go in to > complement the API changes made in 0.13 to support these fixes. David > can make that call. I'd support this. Cheers, Justus