From: Austin Clements <amdragon@MIT.EDU>
To: Justus Winter <4winter@informatik.uni-hamburg.de>
Cc: tomi.ollila@iki.fi, notmuch@notmuchmail.org
Subject: Re: [PATCH 2/5] go: Update for changes to notmuch_database_get_directory
Date: Sun, 13 May 2012 19:15:12 -0400 [thread overview]
Message-ID: <20120513231512.GN11804@mit.edu> (raw)
In-Reply-To: <20120513215135.15106.40581@thinkbox.jade-hamburg.de>
Quoth Justus Winter on May 13 at 11:51 pm:
> Hi Austin,
>
> thanks for taking care of this.
>
> Quoting Austin Clements (2012-05-13 21:57:06)
> > ---
> > bindings/go/src/notmuch/notmuch.go | 13 +++++++------
> > bindings/python/notmuch/database.py | 4 ++--
>
> A change to the python bindings slipped into this one.
Sure enough. I'll send a v2 that moves that hunk to the python patch.
> Other than that this looks good.
>
> I just saw that I marked another function as problematic,
> notmuch_database_find_message_by_filename ends up calling
> _notmuch_directory_create that aborts if the database is not
> writable. But this might have to wait and might not even requira an
> api change.
Right. notmuch_database_find_message_by_filename already has a status
return, so its API is fine. (Actually, I was starting to fix its
implementation when I realized notmuch_database_get_directory was
problematic.)
> Justus
next prev parent reply other threads:[~2012-05-13 23:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-13 19:57 [PATCH 0/5] Fix notmuch_database_get_directory API Austin Clements
2012-05-13 19:57 ` [PATCH 1/5] lib/cli: Make notmuch_database_get_directory return a status code Austin Clements
2012-05-13 19:57 ` [PATCH 2/5] go: Update for changes to notmuch_database_get_directory Austin Clements
2012-05-13 21:51 ` Justus Winter
2012-05-13 23:15 ` Austin Clements [this message]
2012-05-13 19:57 ` [PATCH 3/5] python: " Austin Clements
2012-05-13 19:57 ` [PATCH 4/5] ruby: " Austin Clements
2012-05-13 19:57 ` [PATCH 5/5] news: " Austin Clements
2012-05-13 20:49 ` [PATCH 0/5] Fix notmuch_database_get_directory API Tomi Ollila
2012-05-13 21:55 ` Justus Winter
2012-05-13 23:36 ` [PATCH v2 " Austin Clements
2012-05-13 23:36 ` [PATCH v2 1/5] lib/cli: Make notmuch_database_get_directory return a status code Austin Clements
2012-05-13 23:36 ` [PATCH v2 2/5] go: Update for changes to notmuch_database_get_directory Austin Clements
2012-05-13 23:36 ` [PATCH v2 3/5] python: " Austin Clements
2012-05-13 23:36 ` [PATCH v2 4/5] ruby: " Austin Clements
2012-05-13 23:36 ` [PATCH v2 5/5] news: " Austin Clements
2012-05-15 12:04 ` [PATCH v2 0/5] Fix notmuch_database_get_directory API David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120513231512.GN11804@mit.edu \
--to=amdragon@mit.edu \
--cc=4winter@informatik.uni-hamburg.de \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).