From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 1E6D8431FB6 for ; Fri, 4 May 2012 11:43:24 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NemnAhXBtAO7 for ; Fri, 4 May 2012 11:43:23 -0700 (PDT) Received: from dmz-mailsec-scanner-1.mit.edu (DMZ-MAILSEC-SCANNER-1.MIT.EDU [18.9.25.12]) by olra.theworths.org (Postfix) with ESMTP id 781F3431FAE for ; Fri, 4 May 2012 11:43:23 -0700 (PDT) X-AuditID: 1209190c-b7fad6d000000920-54-4fa4234ab509 Received: from mailhub-auth-2.mit.edu ( [18.7.62.36]) by dmz-mailsec-scanner-1.mit.edu (Symantec Messaging Gateway) with SMTP id BE.9D.02336.A4324AF4; Fri, 4 May 2012 14:43:23 -0400 (EDT) Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id q44IhLjI002770; Fri, 4 May 2012 14:43:22 -0400 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) (authenticated bits=0) (User authenticated as amdragon@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q44IhKv9009567 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Fri, 4 May 2012 14:43:21 -0400 (EDT) Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) (envelope-from ) id 1SQNTM-0005Mc-GK; Fri, 04 May 2012 14:43:20 -0400 Date: Fri, 4 May 2012 14:43:20 -0400 From: Austin Clements To: Justus Winter <4winter@informatik.uni-hamburg.de> Subject: Re: [PATCH 1/5] go: reorganize the go bindings Message-ID: <20120504184320.GO2704@mit.edu> References: <20120430195420.2528.48612@thinkbox.jade-hamburg.de> <1335815744-15258-1-git-send-email-4winter@informatik.uni-hamburg.de> <20120504183822.GN2704@mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120504183822.GN2704@mit.edu> User-Agent: Mutt/1.5.21 (2010-09-15) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupnleLIzCtJLcpLzFFi42IRYrdT0fVWXuJvsP05k8Xs1h9MFtdvzmR2 YPKYeP40m8ezVbeYA5iiuGxSUnMyy1KL9O0SuDLOf/3GWvCXreL08oIGxn2sXYwcHBICJhIX mi27GDmBTDGJC/fWs3UxcnEICexjlPh08gwrhLOeUeLtq05mCOcEk8Tfmz+hypYwSlxY8YUd pJ9FQEVi84u/LCA2m4CGxLb9yxlBbBEBU4kNDx6A1TALSEt8+93MBGILC5hLzJ7ykg3E5hXQ lnj96zs7xNBVjBLre/oYIRKCEidnPmGBaNaSuPHvJRPI3SCDlv/jAAlzCuhI3FuwGqxcFOiG KSe3sU1gFJqFpHsWku5ZCN0LGJlXMcqm5Fbp5iZm5hSnJusWJyfm5aUW6Rrq5WaW6KWmlG5i BIU1pyTPDsY3B5UOMQpwMCrx8O7mWOIvxJpYVlyZe4hRkoNJSZQ3QB4oxJeUn1KZkVicEV9U mpNafIhRgoNZSYQ36etifyHelMTKqtSifJiUNAeLkjivitY7PyGB9MSS1OzU1ILUIpisDAeH kgSvuhLQUMGi1PTUirTMnBKENBMHJ8hwHqDhHCA1vMUFibnFmekQ+VOMuhzzpmy9yijEkpef lyolzssJUiQAUpRRmgc3B5aOXjGKA70lzCsGUsUDTGVwk14BLWECWiJtsAhkSUkiQkqqgXFH pU+6T8NRt7ka7n6VSXGqpabhKXe6H22yUj53L/y07MEvJ2w/eBRYTPTq1+P0+3fz0YOKgLOa 3Lu9zrz6EdN19O7xYl2/xTMcL1dYK70OKHptuSLz67IVtgxnTEN4t/kW8Jw52qPE9v3Cmuss 0i+vpq9KOxj648TCp+/Uebyvx92VPWXSraTEUpyRaKjFXFScCADNgzFEIgMAAA== Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2012 18:43:24 -0000 Quoth myself on May 04 at 2:38 pm: > Quoth Justus Winter on Apr 30 at 9:55 pm: > > Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de> > > Whole series LGTM (and yay gofmt!). I have only two minor comments. > > It would be nice to have a little more log message for some of these. > Mostly the first one could use some explanation of why you're > rearranging the source tree and a mention that there are no changes to > the files (since this is hard to get from the diff). > > It would also be nice if this could optionally be built using the > libnotmuch and notmuch.h directly from the source tree containing the > Go bindings, rather than requiring them to be installed system-wide. > I don't know Go 1's build system well enough to know if there's an > easy way to do this. Oh, also a news patch would be good, though that can obviously be separate.