From: Austin Clements <amdragon@MIT.EDU>
To: Justus Winter <4winter@informatik.uni-hamburg.de>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH 1/5] go: reorganize the go bindings
Date: Fri, 4 May 2012 14:43:20 -0400 [thread overview]
Message-ID: <20120504184320.GO2704@mit.edu> (raw)
In-Reply-To: <20120504183822.GN2704@mit.edu>
Quoth myself on May 04 at 2:38 pm:
> Quoth Justus Winter on Apr 30 at 9:55 pm:
> > Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
>
> Whole series LGTM (and yay gofmt!). I have only two minor comments.
>
> It would be nice to have a little more log message for some of these.
> Mostly the first one could use some explanation of why you're
> rearranging the source tree and a mention that there are no changes to
> the files (since this is hard to get from the diff).
>
> It would also be nice if this could optionally be built using the
> libnotmuch and notmuch.h directly from the source tree containing the
> Go bindings, rather than requiring them to be installed system-wide.
> I don't know Go 1's build system well enough to know if there's an
> easy way to do this.
Oh, also a news patch would be good, though that can obviously be
separate.
next prev parent reply other threads:[~2012-05-04 18:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-28 21:45 [PATCH] go: Update to the current notmuch_database_find_message API Austin Clements
2012-04-30 11:53 ` David Bremner
2012-04-30 19:54 ` Justus Winter
2012-04-30 19:55 ` [PATCH 1/5] go: reorganize the go bindings Justus Winter
2012-04-30 19:55 ` [PATCH 2/5] go: set LDFLAGS, fix include directive Justus Winter
2012-04-30 19:55 ` [PATCH 3/5] go: update the addrlookup utility to go 1 Justus Winter
2012-04-30 19:55 ` [PATCH 4/5] go: update the build system Justus Winter
2012-04-30 19:55 ` [PATCH 5/5] go: format the souce code using gofmt Justus Winter
2012-05-04 18:38 ` [PATCH 1/5] go: reorganize the go bindings Austin Clements
2012-05-04 18:43 ` Austin Clements [this message]
2012-05-05 11:15 ` Justus Winter
2012-05-09 11:15 ` [patch v2] update the go stuff to go 1 Justus Winter
2012-05-09 11:15 ` [PATCH 1/5] go: reorganize the go bindings Justus Winter
2012-05-09 11:15 ` [PATCH 2/5] go: set LDFLAGS to -lnotmuch in the packages source file Justus Winter
2012-05-09 11:15 ` [PATCH 3/5] go: update the addrlookup utility to go 1 Justus Winter
2012-05-09 11:15 ` [PATCH 4/5] go: update the build system Justus Winter
2012-05-09 11:15 ` [PATCH 5/5] go: format the souce code using gofmt Justus Winter
2012-05-09 18:10 ` [patch v2] update the go stuff to go 1 Austin Clements
2012-05-11 11:48 ` David Bremner
2012-04-30 20:14 ` [PATCH] go: Update to the current notmuch_database_find_message API Sebastien Binet
2012-05-04 11:56 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120504184320.GO2704@mit.edu \
--to=amdragon@mit.edu \
--cc=4winter@informatik.uni-hamburg.de \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).