From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 55D9E431FB6 for ; Fri, 4 May 2012 11:38:27 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id T7kMg6Sq7jRc for ; Fri, 4 May 2012 11:38:26 -0700 (PDT) Received: from dmz-mailsec-scanner-2.mit.edu (DMZ-MAILSEC-SCANNER-2.MIT.EDU [18.9.25.13]) by olra.theworths.org (Postfix) with ESMTP id B051B431FAE for ; Fri, 4 May 2012 11:38:26 -0700 (PDT) X-AuditID: 1209190d-b7fbf6d0000008ba-72-4fa42221b4d0 Received: from mailhub-auth-3.mit.edu ( [18.9.21.43]) by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP id 18.47.02234.12224AF4; Fri, 4 May 2012 14:38:25 -0400 (EDT) Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id q44IcOep024226; Fri, 4 May 2012 14:38:25 -0400 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) (authenticated bits=0) (User authenticated as amdragon@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q44IcNZh007947 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Fri, 4 May 2012 14:38:24 -0400 (EDT) Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) (envelope-from ) id 1SQNOY-0005I4-Vn; Fri, 04 May 2012 14:38:23 -0400 Date: Fri, 4 May 2012 14:38:22 -0400 From: Austin Clements To: Justus Winter <4winter@informatik.uni-hamburg.de> Subject: Re: [PATCH 1/5] go: reorganize the go bindings Message-ID: <20120504183822.GN2704@mit.edu> References: <20120430195420.2528.48612@thinkbox.jade-hamburg.de> <1335815744-15258-1-git-send-email-4winter@informatik.uni-hamburg.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1335815744-15258-1-git-send-email-4winter@informatik.uni-hamburg.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjleLIzCtJLcpLzFFi42IR4hTV1lVUWuJvcGWnlcXs1h9MFtdvzmR2 YPKYeP40m8ezVbeYA5iiuGxSUnMyy1KL9O0SuDI6Pl1kL3jFWnH/733GBsZrLF2MHBwSAiYS nyfHdjFyApliEhfurWfrYuTiEBLYxyjx4tAPFghnPaNE+/sXUM4JJomZW+cyQjhLGCVmP7zM BjKKRUBF4v8MZZBRbAIaEtv2L2cEsUUETCU2PHjADmIzC0hLfPvdzARiCwuYS8ye8pINxOYV 0JboX/4danUHo8TPs01MEAlBiZMzn7BANGtJ3Pj3kglkF8ig5f84QExOgSCJs69zQCpEgS6Y cnIb2wRGoVlImmchaZ6F0LyAkXkVo2xKbpVubmJmTnFqsm5xcmJeXmqRrpFebmaJXmpK6SZG cFBL8u5gfHdQ6RCjAAejEg9vJu8SfyHWxLLiytxDjJIcTEqivAHyQCG+pPyUyozE4oz4otKc 1OJDjBIczEoivElfF/sL8aYkVlalFuXDpKQ5WJTEeVW13vkJCaQnlqRmp6YWpBbBZGU4OJQk ePMVgYYKFqWmp1akZeaUIKSZODhBhvMADRcGqeEtLkjMLc5Mh8ifYtTlmDdl61VGIZa8/LxU KXHecpAiAZCijNI8uDmwZPSKURzoLWHeOJAqHmAig5v0CmgJE9ASaYNFIEtKEhFSUg2M11+5 xzm2Fr6acv1i+V+59SYVa8O2zanquv9dj/OzhJbruwNL79rPe640hXvZoa9b5/kWsLX99DU7 l97erB80mZff8dzC1sviCX+6hexbLJVaVlyWWFx3Unu96KM4/pCyyfFm9V1va08s5DhhvPAY 91Qf1wdt95utj7K/fSEwrfyuytKV032blFiKMxINtZiLihMBv5H5XyEDAAA= Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2012 18:38:27 -0000 Quoth Justus Winter on Apr 30 at 9:55 pm: > Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de> Whole series LGTM (and yay gofmt!). I have only two minor comments. It would be nice to have a little more log message for some of these. Mostly the first one could use some explanation of why you're rearranging the source tree and a mention that there are no changes to the files (since this is hard to get from the diff). It would also be nice if this could optionally be built using the libnotmuch and notmuch.h directly from the source tree containing the Go bindings, rather than requiring them to be installed system-wide. I don't know Go 1's build system well enough to know if there's an easy way to do this.