From: Stefano Zacchiroli <zack@upsilon.cc>
To: Taylor Carpenter <taylor@codecafe.com>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH] replace gnu xargs usage in notmuch-mutt with perl
Date: Tue, 10 Apr 2012 10:25:52 +0200 [thread overview]
Message-ID: <20120410082552.GA10872@upsilon.cc> (raw)
Hi Taylor, thanks for your patch. It makes sense to me, and has the
beneficial side effect of avoiding a sed pass to do some poor men shell
escaping.
Before applying, however, can you please update it to:
- include a reasonable comment (as suggested by David)
- avoid patching the shebang line (ditto)
- coalesce the sprintf() line into the following symlink line (using
sprintf seems redundant here: it's plain string concatenation)
Thanks!
Cheers.
PS please Cc:-me on replies
--
Stefano Zacchiroli zack@{upsilon.cc,pps.jussieu.fr,debian.org} . o .
Maître de conférences ...... http://upsilon.cc/zack ...... . . o
Debian Project Leader ....... @zack on identi.ca ....... o o o
« the first rule of tautology club is the first rule of tautology club »
next reply other threads:[~2012-04-10 8:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 8:25 Stefano Zacchiroli [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-04-09 21:11 [PATCH] replace gnu xargs usage in notmuch-mutt with perl Taylor Carpenter
2012-04-09 22:17 ` David Bremner
2012-04-10 16:28 ` Tomi Ollila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120410082552.GA10872@upsilon.cc \
--to=zack@upsilon.cc \
--cc=notmuch@notmuchmail.org \
--cc=taylor@codecafe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).