From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 948C9431FAF for ; Tue, 27 Mar 2012 14:57:25 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id s4HEjwPW0Ytm for ; Tue, 27 Mar 2012 14:57:25 -0700 (PDT) Received: from dmz-mailsec-scanner-2.mit.edu (DMZ-MAILSEC-SCANNER-2.MIT.EDU [18.9.25.13]) by olra.theworths.org (Postfix) with ESMTP id 1BCCE431FAE for ; Tue, 27 Mar 2012 14:57:25 -0700 (PDT) X-AuditID: 1209190d-b7fbf6d0000008ba-91-4f7237c44618 Received: from mailhub-auth-3.mit.edu ( [18.9.21.43]) by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP id 07.FC.02234.4C7327F4; Tue, 27 Mar 2012 17:57:24 -0400 (EDT) Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id q2RLvNaQ022696; Tue, 27 Mar 2012 17:57:23 -0400 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) (authenticated bits=0) (User authenticated as amdragon@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q2RLvKQc013697 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Tue, 27 Mar 2012 17:57:22 -0400 (EDT) Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) (envelope-from ) id 1SCeOG-0002Dr-30; Tue, 27 Mar 2012 17:57:20 -0400 Date: Tue, 27 Mar 2012 17:57:20 -0400 From: Austin Clements To: Tomi Ollila Subject: Re: [PATCH 0/3] Rewrite default reply format Message-ID: <20120327215720.GX2670@mit.edu> References: <1332473647-9133-1-git-send-email-amdragon@mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpileLIzCtJLcpLzFFi42IR4hTV1j1iXuRvcPoTn8X1mzOZLd6snMfq wORx+OtCFo9nq24xBzBFcdmkpOZklqUW6dslcGX8/NnMUjCDs6J39SaWBsY57F2MnBwSAiYS 8y4sZYSwxSQu3FvP1sXIxSEksI9RouX0JDaQhJDABkaJ3xsyIRInmSRaD+6CSixhlFi7UxvE ZhFQlbjTdYgZxGYT0JDYtn852FQRARWJB23rWUFsZgFpiW+/m5lAbGEBU4lZa+6DXcEroC2x 8NEWJoiZqRIrD6xghogLSpyc+YQFoldL4sa/l0A1HGBzlv/jAAlzChhI/PzxAmy8KNCqKSe3 sU1gFJqFpHsWku5ZCN0LGJlXMcqm5Fbp5iZm5hSnJusWJyfm5aUW6Rrp5WaW6KWmlG5iBAe1 JO8OxncHlQ4xCnAwKvHwVjMV+QuxJpYVV+YeYpTkYFIS5VUwBQrxJeWnVGYkFmfEF5XmpBYf YpTgYFYS4dWOKvQX4k1JrKxKLcqHSUlzsCiJ86pqvfMTEkhPLEnNTk0tSC2CycpwcChJ8PIB o1dIsCg1PbUiLTOnBCHNxMEJMpwHaPhnM6Aa3uKCxNzizHSI/ClGRSlx3o8gCQGQREZpHlwv LOm8YhQHekWY9xtIFQ8wYcF1vwIazAQ0eMmRfJDBJYkIKakGxv3zZtTdC//h+mlx0bL2XNUr 050rn8WlTdWb6PYulO9PJuvXyMrTG84cyXCxZD7oNyvfgDk9bqVh2c+ttc/DK72THtenhS00 r4jacH3bOoFV8amMn3Z1hbKHP5mtMbvotb0J0+8y13xGKfuq+Ts8tJTEH1/Kkha9wfO8TGx6 wALtbcFvd/cnKbEUZyQaajEXFScCAJEwQKEVAwAA Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Mar 2012 21:57:25 -0000 Thanks for the review. New version coming shortly... Quoth Tomi Ollila on Mar 24 at 12:06 pm: > Austin Clements writes: > > > The default reply format is the last bastion of the old message > > formatter style. This series converts it to the new self-recursive > > style. After this, there will be one last series to rip out the > > compatibility code and do final cleanup. > > Works fine, patches look good... just 2 "spacing" questions: > > in id:"1332473647-9133-2-git-send-email-amdragon@mit.edu" > > + typedef enum { > + NOTMUCH_SHOW_TEXT_PART_REPLY = 1<<0, > + } notmuch_show_text_part_flags; > > Should this be like: NOTMUCH_SHOW_TEXT_PART_REPLY = (1 << 0), Changed to NOTMUCH_SHOW_TEXT_PART_REPLY = 1 << 0 to be consistent with operator spacing. I left out the parens since they aren't necessary. > and this > > + * If flags&NOTMUCH_SHOW_TEXT_PART_REPLY, this prepends "> " to each > + * output line. > + * > > like: > > + * If flags & NOTMUCH_SHOW_TEXT_PART_REPLY, this prepends "> " to each Changed. On this one I put in parens to better distinguish it from the surrounding prose. > Tomi