From: Austin Clements <amdragon@MIT.EDU>
To: David Bremner <david@tethera.net>
Cc: notmuch@notmuchmail.org
Subject: Re: Patches for 0.12
Date: Wed, 14 Mar 2012 18:16:01 -0400 [thread overview]
Message-ID: <20120314221601.GN2787@mit.edu> (raw)
In-Reply-To: <87k42stuno.fsf@zancas.localnet>
Quoth David Bremner on Mar 10 at 10:09 am:
>
> As usual, nothing brings out the bug reports like a freeze.
>
> There are some patches that should probably go in, but could use one
> more pair of eyes.
>
> id:"1330849538-24558-1-git-send-email-jani@nikula.org"
I looked at this and just sent a question to Jani
id:"87k42momyi.fsf@awakening.csail.mit.edu"
If the answer is that it's okay, then consider my eyes one more pair.
> We had a somewhat lively debate about desirablity of the following
> patch. My decision is that for now, we avoid changing the behaviour of
> notmuch, and do apply the patch. We can discuss later deprecating or
> changing this permissive behaviour.
>
> id:"1331385931-1610-1-git-send-email-david@tethera.net"
Alternatively, can we just require GMime 2.6.7 by applying
id:"1331515786-485-1-git-send-email-david@tethera.net"
instead of
id:"1331385931-1610-1-git-send-email-david@tethera.net"
and
id:"1329852935-3019-1-git-send-email-schnouki@schnouki.net"
?
> This patch from Austin seems innocent enough, and I plan to push it to
> release.
>
> id:"1331058417-13776-1-git-send-email-amdragon@mit.edu"
The worst-case scenario with applying this patch is that notmuch will
verbosely fail to show a message where it would otherwise crash, so
I'd go for it.
> I'm not sure about including
>
> id:"1329852935-3019-1-git-send-email-schnouki@schnouki.net"
>
> it wouldn't really help debian (as the unstable buildds already have
> 2.6.6), but I guess it might help others building debian packages.
(See my comment about 2.6.7 above.)
> Although
>
> id:"1331225101-24385-1-git-send-email-jrollins@finestructure.net"
>
> is marked as trivial and is certainly short, I'd like one more pair of
> eyes before pushing to release.
I approve this patch.
next prev parent reply other threads:[~2012-03-14 22:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-10 14:09 Patches for 0.12 David Bremner
2012-03-14 21:45 ` anecdotical evidence: number mbox files in my maildirs (was: Re: Patches for 0.12) Gregor Zattler
2012-03-14 20:49 ` anecdotical evidence: number mbox files in my maildirs Daniel Kahn Gillmor
2012-03-14 22:16 ` Austin Clements [this message]
2012-03-14 22:40 ` Patches for 0.12 Jameson Graef Rollins
2012-03-15 21:17 ` Austin Clements
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120314221601.GN2787@mit.edu \
--to=amdragon@mit.edu \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).