From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olly@survex.com>
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id E950A431FB6
	for <notmuch@notmuchmail.org>; Thu,  1 Mar 2012 13:20:47 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -2.3
X-Spam-Level: 
X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5
	tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id sB89M8KcWBs3 for <notmuch@notmuchmail.org>;
	Thu,  1 Mar 2012 13:20:47 -0800 (PST)
Received: from atreus.tartarus.org (atreus.tartarus.org [80.252.125.10])
	(using TLSv1 with cipher AES256-SHA (256/256 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id 49FE0431FAF
	for <notmuch@notmuchmail.org>; Thu,  1 Mar 2012 13:20:47 -0800 (PST)
Received: from olly by atreus.tartarus.org with local (Exim 4.69)
	(envelope-from <olly@survex.com>)
	id 1S3DQX-0001YB-57; Thu, 01 Mar 2012 21:20:41 +0000
Date: Thu, 1 Mar 2012 21:20:41 +0000
From: Olly Betts <olly@survex.com>
To: Justus Winter <4winter@informatik.uni-hamburg.de>
Subject: Re: [PATCH] Actually close the xapian database in
 notmuch_database_close
Message-ID: <20120301212040.GW24964@survex.com>
References: <1330507157-22859-1-git-send-email-4winter@informatik.uni-hamburg.de>
	<1330507157-22859-2-git-send-email-4winter@informatik.uni-hamburg.de>
	<20120229154833.GB772@mit.edu> <20120229211922.GQ24964@survex.com>
	<20120229221754.GD772@mit.edu>
	<20120301065930.5076.72748@thinkbox.jade-hamburg.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20120301065930.5076.72748@thinkbox.jade-hamburg.de>
User-Agent: Mutt/1.5.18 (2008-05-17)
Cc: notmuch@notmuchmail.org
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Mar 2012 21:20:48 -0000

On Thu, Mar 01, 2012 at 07:59:30AM +0100, Justus Winter wrote:
> Olly wrote:
> >It is hard to say if calling close() is actually useful here from just
> >seeing the patch.
> 
> Huh? I provided a test case...

I only saw the part of the patch Austin quoted in the mail he cc-ed to
me.

> Quoting Austin Clements (2012-02-29 23:17:54)
> >Also, since close could throw an exception, it should get wrapped in a
> >try/catch like flush currently is.
> 
> My interpretation of [0] was that Xapian::Database::close() does not
> throw any exceptions.

Sadly there's not full documentation of exceptions which can be thrown 
by a particular method.

Cheers,
    Olly