From: Olly Betts <olly@survex.com>
To: Justus Winter <4winter@informatik.uni-hamburg.de>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH] Actually close the xapian database in notmuch_database_close
Date: Thu, 1 Mar 2012 21:20:41 +0000 [thread overview]
Message-ID: <20120301212040.GW24964@survex.com> (raw)
In-Reply-To: <20120301065930.5076.72748@thinkbox.jade-hamburg.de>
On Thu, Mar 01, 2012 at 07:59:30AM +0100, Justus Winter wrote:
> Olly wrote:
> >It is hard to say if calling close() is actually useful here from just
> >seeing the patch.
>
> Huh? I provided a test case...
I only saw the part of the patch Austin quoted in the mail he cc-ed to
me.
> Quoting Austin Clements (2012-02-29 23:17:54)
> >Also, since close could throw an exception, it should get wrapped in a
> >try/catch like flush currently is.
>
> My interpretation of [0] was that Xapian::Database::close() does not
> throw any exceptions.
Sadly there's not full documentation of exceptions which can be thrown
by a particular method.
Cheers,
Olly
prev parent reply other threads:[~2012-03-01 21:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 9:19 fix notmuch_database_close Justus Winter
2012-02-29 9:19 ` [PATCH] Actually close the xapian database in notmuch_database_close Justus Winter
2012-02-29 15:48 ` Austin Clements
2012-02-29 21:19 ` Olly Betts
2012-02-29 22:17 ` Austin Clements
2012-03-01 6:59 ` Justus Winter
2012-03-01 18:11 ` Austin Clements
2012-03-02 14:58 ` Justus Winter
2012-03-03 16:18 ` David Bremner
2012-03-01 21:20 ` Olly Betts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120301212040.GW24964@survex.com \
--to=olly@survex.com \
--cc=4winter@informatik.uni-hamburg.de \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).