From: Serge Z <triumhiz@yandex.ru>
To: notmuch@notmuchmail.org
Subject: Re: [PATCH] test: Add test for searching of uncommonly encoded messages
Date: Fri, 24 Feb 2012 11:57:00 +0400 [thread overview]
Message-ID: <20120224075700.13214.28221@localhost> (raw)
In-Reply-To: <874nug67il.fsf@steelpick.2x.cz>
Quoting Michal Sojka (2012-02-24 11:00:02)
>On Fri, 24 Feb 2012, Serge Z wrote:
>>
>> Quoting Michal Sojka (2012-02-24 04:33:15)
>> >Emails that are encoded differently than as ASCII or UTF-8 are not
>> >indexed properly by notmuch. It is not possible to search for non-ASCII
>> >words within those messages.
>>
>> Ok. But we can preprocess each incoming message right after 'getmail' to
>> convert it from html to text and to utf8 encoding. One solution is to create a
>> seperate script for this and make gmail pipe all messages to this script, and
>> then to notmuch. But It would be better if maildir contains original messages
>> only, so the question is: can we make nomuch indexing engine to index
>> preprocessed message while maildir will contain original message - as it was
>> obtained?
>
>Hi,
>
>I'm not big fan of adding "preprocessor". First, I thing that both
>reasons you mention are actually bugs and it would be better to fix them
>for everybody than requiring each user to configure some preprocessor.
>Second, depending on what and how would your preprocessor do, the
>initial mail indexing could be a way slower, which is also nothing that
>people want.
>
>Do you have any other use case for the preprocessor besides utf8 and
>html->text conversions?
>
>Cheers,
>-Michal
Well, I don't want to add any external preprocessor too.
This may be considered as an architectural decision: search engine should not
access messages directly, but through some preprocessing layer which would
handle the case of different encodings in body and headers, RFC2047-encoded
headers (if this is not handled yet) etc.
Anyway, this solution imho would be nice to be concluded inside a separate
library which would be useful for notmuch clients as well as other mail
indexing engines. Or an existing library should be looked for.
next prev parent reply other threads:[~2012-02-24 7:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-22 17:10 Searching through different charsets Serge Z
2012-02-24 0:31 ` Michal Sojka
2012-02-24 0:33 ` [PATCH] test: Add test for searching of uncommonly encoded messages Michal Sojka
2012-02-24 4:29 ` Serge Z
2012-02-24 7:00 ` Michal Sojka
2012-02-24 7:57 ` Serge Z [this message]
2012-02-24 8:38 ` Michal Sojka
2012-02-25 8:36 ` Serge Z
2012-02-26 9:33 ` Double decoded text/html parts (was: [PATCH] test: Add test for searching of uncommonly encoded messages) Michal Sojka
2012-02-26 10:20 ` Serge Z
2012-02-24 7:36 ` [PATCH 1/2] Convert non-UTF-8 parts to UTF-8 before indexing them Michal Sojka
2012-02-24 7:36 ` [PATCH 2/2] test: Remove 'broken' flag from encoding test Michal Sojka
2012-02-25 4:33 ` [PATCH 1/2] Convert non-UTF-8 parts to UTF-8 before indexing them Austin Clements
2012-02-29 11:55 ` David Bremner
2012-02-29 11:55 ` [PATCH] test: Add test for searching of uncommonly encoded messages David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120224075700.13214.28221@localhost \
--to=triumhiz@yandex.ru \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).