From: Justus Winter <4winter@informatik.uni-hamburg.de>
To: notmuch mailing list <notmuch@notmuchmail.org>,
Subject: notmuch as a shared object aka library knigge
Date: Tue, 21 Feb 2012 00:29:21 -0000
Date: Tue, 21 Feb 2012 01:29:21 +0100 [thread overview]
Message-ID: <20120221002921.8534.57091@thinkbox.jade-hamburg.de> (raw)
Hi fellow notmuchrs,
while going through the python bindings I recently came across the
following note in the documentation for the Database.get_directory
function [0]:
~~~ snip ~~~
Warning
This call needs a writable database in Database.MODE.READ_WRITE
mode. The underlying library will exit the program if this method is
used on a read-only database!
~~~ snap ~~~
and indeed, the following program exits with an error:
~~~ snip ~~~
import os
import notmuch
db_path = os.path.expanduser('~/Maildir')
with notmuch.Database(db_path, mode=notmuch.Database.MODE.READ_ONLY) as db:
db.get_directory('')
~~~ snap ~~~
% python temp/get_directory.py
Internal error: Failure to ensure database is writable (lib/directory.cc:100).
The line mentioned in the error message reads:
if (notmuch->mode == NOTMUCH_DATABASE_MODE_READ_ONLY)
INTERNAL_ERROR ("Failure to ensure database is writable");
with
/* There's no point in continuing when we've detected that we've done
* something wrong internally (as opposed to the user passing in a
* bogus value).
*
* Note that __location__ comes from talloc.h.
*/
#define INTERNAL_ERROR(format, ...) \
_internal_error (format " (%s).\n", \
##__VA_ARGS__, __location__)
and _internal_error calling exit(3).
If creating a shared library is the preferred way to increase the
startup time of the notmuch binary that's totally cool, but if
libnotmuch is to be used as a library for arbitrary programs it is not
acceptable to call exit(3).
(And as mentioned before, neither is writing to any file descriptor
unless it has been specifically requested by the caller.)
Cheers,
Justus
0: http://notmuch.readthedocs.org/en/latest/index.html#notmuch.Database.get_directory
next reply other threads:[~2012-02-21 0:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-21 0:29 Justus Winter [this message]
2012-02-21 15:35 ` notmuch as a shared object aka library knigge Patrick Totzke
2012-02-21 15:53 ` Austin Clements
2012-02-22 15:17 ` Justus Winter
2012-02-23 22:22 ` Justus Winter
2012-02-24 0:29 ` David Bremner
2012-02-24 1:04 ` Justus Winter
2012-02-24 0:33 ` David Bremner
2012-02-24 1:08 ` Justus Winter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120221002921.8534.57091@thinkbox.jade-hamburg.de \
--to=4winter@informatik.uni-hamburg.de \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).