From: Austin Clements <amdragon@MIT.EDU>
To: Tomi Ollila <tomi.ollila@iki.fi>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH 0/8] Rewrite JSON show format
Date: Wed, 15 Feb 2012 13:15:43 -0500 [thread overview]
Message-ID: <20120215181543.GV27039@mit.edu> (raw)
In-Reply-To: <m2obt0dtv8.fsf@guru.guru-group.fi>
Quoth Tomi Ollila on Feb 15 at 5:00 pm:
> On Tue, 14 Feb 2012 12:33:35 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> > The saga continues. As for the text format, this first shifts lots of
> > code around without changing its semantics, then it dives in and
> > simplifies a lot of things. Don't be put off by the number of
> > patches; most of them are straightforward.
> >
> > As an added bonus, I documented (!) the JSON format for both show and
> > search.
>
> I got 2 trailing whitespace "errors" when applied (schemata) patches.
Oops. Will fix in v2.
>
> Emacs MUA works for me.
>
> Most json-related tests pass (for me), but I get this:
>
> FAIL notmuch-show for message with invalid From
> --- emacs.10.expected 2012-02-15 14:28:48.000000000 +0000
> +++ emacs.10.output 2012-02-15 14:28:48.000000000 +0000
> @@ -1,4 +1,4 @@
> -"Invalid " (2001-01-05) (inbox)
> +Invalid From <test_suite@notmuchmail.org> <q> (2001-01-05) (inbox)
>
> If this works for others then the problem is in my setup
> (I have 8 other tests failing for various other reasons)
>
> The patch in id:"1329240823-7856-5-git-send-email-amdragon@mit.edu"
> changes this -- the + line is almost like it was (without that <q>).
> Maybe the reason is within gmime-2.4.20-1.el5.rf I'm having in this
> machine -- have to try on another...
>
> ...YES. other machine has (self-compiled) gmime 2.4.25 and there I got
The from header is now being parsed by gmime, so if gmime's parsing of
invalid headers has changed, it's quite possible it would affect this
test.
> All 370 tests behaved as expected (2 expected failures).
>
> Code LGTM.
>
> +1
>
> Tomi
next prev parent reply other threads:[~2012-02-15 18:17 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-14 17:33 [PATCH 0/8] Rewrite JSON show format Austin Clements
2012-02-14 17:33 ` [PATCH 1/8] Document the JSON schemata used by show and search Austin Clements
2012-02-14 17:33 ` [PATCH 2/8] show: Convert JSON format to the new self-recursive style Austin Clements
2012-02-14 17:33 ` [PATCH 3/8] show: Use consistent header ordering in the JSON format Austin Clements
2012-02-14 17:33 ` [PATCH 4/8] show: Unify JSON header output for messages and message parts Austin Clements
2012-02-14 17:33 ` [PATCH 5/8] show: Simplify talloc use in format_headers_json Austin Clements
2012-02-14 17:33 ` [PATCH 6/8] show: Make JSON helper functions print complete objects Austin Clements
2012-02-14 17:33 ` [PATCH 7/8] show: Make format_part_sigstatus_json's API consistent between GMIME 2.4 and 2.6 Austin Clements
2012-02-14 17:33 ` [PATCH 8/8] show: Further general simplifications of the JSON formatter Austin Clements
2012-02-15 5:45 ` [PATCH 0/8] Rewrite JSON show format Adam Wolfe Gordon
2012-02-15 15:00 ` Tomi Ollila
2012-02-15 15:20 ` Adam Wolfe Gordon
2012-02-15 18:15 ` Austin Clements [this message]
2012-02-20 0:26 ` [PATCH v2 " Austin Clements
2012-02-20 0:26 ` [PATCH v2 1/8] Document the JSON schemata used by show and search Austin Clements
2012-02-28 2:47 ` David Bremner
2012-02-20 0:26 ` [PATCH v2 2/8] show: Convert JSON format to the new self-recursive style Austin Clements
2012-03-01 12:35 ` David Bremner
2012-02-20 0:26 ` [PATCH v2 3/8] show: Use consistent header ordering in the JSON format Austin Clements
2012-02-20 0:26 ` [PATCH v2 4/8] show: Unify JSON header output for messages and message parts Austin Clements
2012-02-20 0:26 ` [PATCH v2 5/8] show: Simplify talloc use in format_headers_json Austin Clements
2012-02-20 0:26 ` [PATCH v2 6/8] show: Make JSON helper functions print complete objects Austin Clements
2012-02-20 0:26 ` [PATCH v2 7/8] show: Make format_part_sigstatus_json's API consistent between GMIME 2.4 and 2.6 Austin Clements
2012-02-20 0:26 ` [PATCH v2 8/8] show: Further general simplifications of the JSON formatter Austin Clements
2012-02-20 10:17 ` [PATCH v2 0/8] Rewrite JSON show format Tomi Ollila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120215181543.GV27039@mit.edu \
--to=amdragon@mit.edu \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).