From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id C10ED431FAF for ; Fri, 20 Jan 2012 08:42:36 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5fal6IEjwygV for ; Fri, 20 Jan 2012 08:42:36 -0800 (PST) Received: from dmz-mailsec-scanner-8.mit.edu (DMZ-MAILSEC-SCANNER-8.MIT.EDU [18.7.68.37]) by olra.theworths.org (Postfix) with ESMTP id 50AC0431FAE for ; Fri, 20 Jan 2012 08:42:36 -0800 (PST) X-AuditID: 12074425-b7f4a6d0000008e0-ed-4f19997c2f58 Received: from mailhub-auth-4.mit.edu ( [18.7.62.39]) by dmz-mailsec-scanner-8.mit.edu (Symantec Messaging Gateway) with SMTP id 79.84.02272.C79991F4; Fri, 20 Jan 2012 11:42:36 -0500 (EST) Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id q0KGgZtv020928; Fri, 20 Jan 2012 11:42:36 -0500 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) (authenticated bits=0) (User authenticated as amdragon@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q0KGgYVD000856 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Fri, 20 Jan 2012 11:42:35 -0500 (EST) Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) (envelope-from ) id 1RoHXa-00069y-Cq; Fri, 20 Jan 2012 11:42:14 -0500 Date: Fri, 20 Jan 2012 11:42:14 -0500 From: Austin Clements To: Mark Walters Subject: Re: [PATCH v5] Make buttons for attachments allow viewing as well as saving Message-ID: <20120120164214.GZ16740@mit.edu> References: <877h0mww05.fsf@qmul.ac.uk> <1327052646-3422-1-git-send-email-markwalters1009@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1327052646-3422-1-git-send-email-markwalters1009@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpileLIzCtJLcpLzFFi42IRYrdT162ZKelvcG0tu8XquTwW12/OZHZg 8tg56y67x7NVt5gDmKK4bFJSczLLUov07RK4Mu5M2c9a8JW1oufxJMYGxissXYycHBICJhIP GlvZIWwxiQv31rN1MXJxCAnsY5SYvnc+C4SzgVFixaHfTBDOSSaJrjP3mEFahASWMEr0zk4B sVkEVCUWX/4IFmcT0JDYtn85I4gtIqAjcfvQArAVzALSEt9+NzOB2MICYRK/Nk8BO4MXqObZ vmZWiJlpEp1vWpgg4oISJ2c+YYHo1ZK48e8lUJwDbM7yfxwgYU4BT4lDW2+CrRUVUJGYcnIb 2wRGoVlIumch6Z6F0L2AkXkVo2xKbpVubmJmTnFqsm5xcmJeXmqRroVebmaJXmpK6SZGcFC7 qO5gnHBI6RCjAAejEg8vt6uEvxBrYllxZe4hRkkOJiVR3g9TJP2F+JLyUyozEosz4otKc1KL DzFKcDArifCWdQHleFMSK6tSi/JhUtIcLErivJpa7/yEBNITS1KzU1MLUotgsjIcHEoSvGdm ADUKFqWmp1akZeaUIKSZODhBhvMADb8EUsNbXJCYW5yZDpE/xagoJc57BSQhAJLIKM2D64Ul nVeM4kCvCPM+AKniASYsuO5XQIOZgAZ7NImBDC5JREhJNTB6h/U3L+ys89PbdXjP0vnVL2Uf fd69xCgw/kDfpoDD22pYys51zBT0+6/YcVGiobeDS/WpPd+hmbsUb3+J7HVmXy+/5Z7NzJub FI8kiM6y/b/nyTG+73cC/mW8Ey2/c4TZ/UUFQ+Fvo5SExkN/RS9+3PSnhqnQs8EycOmusq21 LTvL7v4/EDlbiaU4I9FQi7moOBEANranDhUDAAA= Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jan 2012 16:42:36 -0000 LGTM Quoth Mark Walters on Jan 20 at 9:44 am: > Define a keymap for attachment buttons to allow multiple actions. > Define 3 possible actions: > save attachment: exactly as currently, > view attachment: uses mailcap entry, > view attachment with user chosen program > > Keymap on a button is: s for save, v for view and o for view with > other program. Default (i.e. enter or mouse button) is save but this > is configurable in notmuch customize. > > One implementation detail: the view attachment function forces all > attachments to be "displayed" using mailcap even if emacs could > display them itself. Thus, for example, text/html appears in a browser > and text/plain asks whether to save (on a standard debian setup)