From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id EF920431FAF for ; Thu, 19 Jan 2012 11:41:35 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id weRxJIocihnp for ; Thu, 19 Jan 2012 11:41:35 -0800 (PST) Received: from dmz-mailsec-scanner-2.mit.edu (DMZ-MAILSEC-SCANNER-2.MIT.EDU [18.9.25.13]) by olra.theworths.org (Postfix) with ESMTP id 48E69431FAE for ; Thu, 19 Jan 2012 11:41:35 -0800 (PST) X-AuditID: 1209190d-b7fbf6d0000008ba-75-4f1871ee7925 Received: from mailhub-auth-1.mit.edu ( [18.9.21.35]) by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP id D2.FB.02234.EE1781F4; Thu, 19 Jan 2012 14:41:34 -0500 (EST) Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id q0JJfYTw015024; Thu, 19 Jan 2012 14:41:34 -0500 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) (authenticated bits=0) (User authenticated as amdragon@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q0JJfXWS013778 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Thu, 19 Jan 2012 14:41:33 -0500 (EST) Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) (envelope-from ) id 1RnxrH-00045q-OP; Thu, 19 Jan 2012 14:41:15 -0500 Date: Thu, 19 Jan 2012 14:41:15 -0500 From: Austin Clements To: Pieter Praet Subject: Re: [PATCH 1/4] search: rename auto_exclude_tags to {search,}exclude_tags Message-ID: <20120119194115.GO16740@mit.edu> References: <1326586654-16840-3-git-send-email-amdragon@mit.edu> <1327000744-25463-1-git-send-email-pieter@praet.org> <1327000744-25463-2-git-send-email-pieter@praet.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1327000744-25463-2-git-send-email-pieter@praet.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmphleLIzCtJLcpLzFFi42IR4hRV1n1XKOFvcH2uucX1mzOZLX6/vsHs wOTxbNUtZo+OfZdZA5iiuGxSUnMyy1KL9O0SuDLWdc1gKnjBWXH18jaWBsYb7F2MnBwSAiYS t+e+ZISwxSQu3FvP1sXIxSEksI9R4uOPSewQzgZGiZnP/jJDOCeZJGY/aGeBcJYwSpw8/was n0VAVWL+jTMsIDabgIbEtv3LweIiAsoSp5/8BNvHLKAlsXXjB7C4sECIxJXVU8HivAI6Ej+m 90GtW8co8Wj+WTaIhKDEyZlPWGCab/x7ydTFyAFkS0ss/8cBYnIKOEqc3SACUiEqoCIx5eQ2 tgmMQrOQNM9C0jwLoXkBI/MqRtmU3Crd3MTMnOLUZN3i5MS8vNQiXSO93MwSvdSU0k2M4MCW 5N3B+O6g0iFGAQ5GJR7eRHcJfyHWxLLiytxDjJIcTEqivN0FQCG+pPyUyozE4oz4otKc1OJD jBIczEoivPNygHK8KYmVValF+TApaQ4WJXFeVa13fkIC6YklqdmpqQWpRTBZGQ4OJQneHmAE CwkWpaanVqRl5pQgpJk4OEGG8wANbwep4S0uSMwtzkyHyJ9iVJQS560FSQiAJDJK8+B6YYnn FaM40CvCvGUgVTzApAXX/QpoMBPQYI8mMZDBJYkIKakGxownuuIXpI6VBytFfla9M/FWikiL YuHj5nsVZ4qO7ox6Utik9F7gb8O59cIb5vS1rQ2d9/l4ScD6Jt5qzuq+te9+TLZa+KVG0e9f 3e+4ne7tLi3XWTLrJzfYahzuPn7H9Ozhb/Mn+LzaxCd3YV2dT218puCs5UGLVvQ9WjTtmodS y2s2g1WmPkosxRmJhlrMRcWJAJEOwKMXAwAA Cc: Notmuch Mail X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jan 2012 19:41:36 -0000 Quoth Pieter Praet on Jan 19 at 8:19 pm: > All other config-related functions and args include the section > title in their name, so for the sake of consistency, mirror that. > > Also, the "auto"matic part is a given, so that was dropped. LGTM other than one nit, below. > --- a/notmuch-config.c > +++ b/notmuch-config.c > @@ -89,9 +89,9 @@ static const char search_config_comment[] = > "\n" > " The following option is supported here:\n" > "\n" > - "\tauto_exclude_tags A ;-separated list of tags that will be\n" > - "\t excluded from search results by default. Using an excluded tag\n" > - "\t in a query will override that exclusion.\n"; > + "\texclude_tags A list (separated by ';') of the tags that will be\n" > + "\t\texcluded from search results by default. Using an excluded tag in a\n" > + "\t\tquery will override that exclusion.\n"; I'd propose that any tag whose name is more than seven characters long should have its description start under it, indented by a tab, like I did in id:"1326920205-31296-1-git-send-email-amdragon@mit.edu". That looks nice and keeps the description indented consistently without ridiculous amounts of negative space and narrow wrapping.