From: Austin Clements <amdragon@MIT.EDU>
To: David Edmondson <dme@dme.org>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] Silence buildbot warnings about unused results
Date: Thu, 19 Jan 2012 13:00:46 -0500 [thread overview]
Message-ID: <20120119180046.GL16740@mit.edu> (raw)
In-Reply-To: <cunehuw6tqu.fsf@hotblack-desiato.hh.sledj.net>
Quoth David Edmondson on Jan 19 at 7:23 am:
> On Wed, 18 Jan 2012 19:40:11 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> > + /* See handle_sigint in notmuch-new.c for the justification for
> > + * ignoring write's result. */
> > + IGNORE_RESULT (write (2, msg, sizeof(msg)-1));
>
> Just include the comment in both places. Someone will work over the code
> in notmuch-new.c and we'll lose it.
Done.
> Then, +1.
next prev parent reply other threads:[~2012-01-19 18:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-19 0:40 [PATCH 0/2] Fix or silence "unused result" warnings Austin Clements
2012-01-19 0:40 ` [PATCH 1/2] show: Handle read and write errors Austin Clements
2012-01-19 0:40 ` [PATCH 2/2] Silence buildbot warnings about unused results Austin Clements
2012-01-19 7:23 ` David Edmondson
2012-01-19 18:00 ` Austin Clements [this message]
2012-01-19 10:49 ` [PATCH 0/2] Fix or silence "unused result" warnings Jani Nikula
2012-01-19 18:01 ` [PATCH v2 1/2] show: Handle read and write errors Austin Clements
2012-01-19 18:01 ` [PATCH v2 2/2] Silence buildbot warnings about unused results Austin Clements
2012-01-19 22:29 ` [PATCH v3 0/2] Austin Clements
2012-01-19 22:29 ` [PATCH v3 1/2] show: Handle read and write errors Austin Clements
2012-01-20 13:59 ` Tomi Ollila
2012-01-21 13:12 ` David Bremner
2012-01-19 22:29 ` [PATCH v3 2/2] Silence buildbot warnings about unused results Austin Clements
2012-01-20 14:00 ` Tomi Ollila
2012-01-21 13:12 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120119180046.GL16740@mit.edu \
--to=amdragon@mit.edu \
--cc=dme@dme.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).