unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Austin Clements <amdragon@MIT.EDU>
To: Pieter Praet <pieter@praet.org>
Cc: Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH v4] emacs: logically group def{custom,face}s
Date: Wed, 18 Jan 2012 13:44:08 -0500	[thread overview]
Message-ID: <20120118184408.GD16740@mit.edu> (raw)
In-Reply-To: <87ipk98h5d.fsf@praet.org>

Quoth Pieter Praet on Jan 18 at 11:00 am:
> On Mon, 16 Jan 2012 14:16:22 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> > LGTM.
> > 
> > Quoth Pieter Praet on Jan 16 at 11:38 am:
> > > - Add `notmuch-send' to the `message' group, as per Austin's
> > >   recommendation [1].
> > 
> > This is actually the reverse of what I was suggesting (though is also
> > reasonable).  Since notmuch uses message-mode, I was saying that the
> > notmuch group (or the notmuch-send group) should link to the message
> > group.  That way, if you customize-group notmuch, you get all of the
> > options that affect notmuch, even those that aren't strictly notmuch
> > variables.
> 
> Sorry, failed to mention;  I tried that, but the additional
> 
>   :link '(custom-group-link :tag "Message" message)
> 
> didn't seem all that useful compared to (or combined with)
> adding `message' as parent group to `notmuch-send':
> 
>   #+begin_example
>     Parent groups: Message Notmuch
> 
>     /- Notmuch Send group: Sending messages from Notmuch.--------------------\
>           State: something in this group has been changed outside customize.
>   #+end_example
> 
> vs.
> 
>   #+begin_example
>     Parent groups: Message Notmuch
> 
>     /- Notmuch Send group: Sending messages from Notmuch.--------------------\
>           State: something in this group has been changed outside customize.
>           See also Message.
>   #+end_example
> 
> ... so I ripped it out again.  Should I add it back?

Hmm.  You're right that the :link doesn't do much.

One other possibility to consider is
  (custom-add-to-group 'notmuch-show 'message 'custom-group)
or even
  (custom-add-to-group 'notmuch 'message 'custom-group)

  reply	other threads:[~2012-01-18 18:44 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-05 18:33 [PATCH] emacs: logically group def{custom,face}s Pieter Praet
2011-10-10 13:49 ` Daniel Schoepe
2011-10-18 15:18   ` Jameson Graef Rollins
2011-11-01 20:00     ` Pieter Praet
2011-11-21  2:51       ` David Bremner
2012-01-12 17:12         ` [PATCH v2] " Pieter Praet
2012-01-13  3:31           ` David Bremner
2012-01-13 16:15             ` David Edmondson
2012-01-14  9:05               ` Pieter Praet
2012-01-14  9:02             ` Pieter Praet
2012-01-14  9:04               ` [PATCH] " Pieter Praet
2012-01-14 18:08                 ` Austin Clements
2012-01-14 20:12                   ` Jameson Graef Rollins
2012-01-16 10:34                   ` Pieter Praet
2012-01-16 10:38                     ` [PATCH v4] " Pieter Praet
2012-01-16 11:02                       ` David Edmondson
2012-01-16 19:16                       ` Austin Clements
2012-01-18 10:00                         ` Pieter Praet
2012-01-18 18:44                           ` Austin Clements [this message]
2012-01-19 19:10                             ` Pieter Praet
2012-01-19 19:13                               ` [PATCH] emacs: invert relation between 'notmuch-send and 'message customization groups Pieter Praet
2012-01-19 19:22                                 ` Austin Clements
2012-01-21 13:13                                 ` David Bremner
2012-01-19 17:14                       ` [PATCH v4] emacs: logically group def{custom,face}s David Bremner
2012-01-19 19:21                         ` Pieter Praet
2012-01-13 20:56           ` [PATCH v2] " Jameson Graef Rollins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120118184408.GD16740@mit.edu \
    --to=amdragon@mit.edu \
    --cc=notmuch@notmuchmail.org \
    --cc=pieter@praet.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).