From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id B15D6429E35 for ; Mon, 16 Jan 2012 16:49:34 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 1.274 X-Spam-Level: * X-Spam-Status: No, score=1.274 tagged_above=-999 required=5 tests=[RDNS_NONE=1.274] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DyKtmfH+pNTe for ; Mon, 16 Jan 2012 16:49:34 -0800 (PST) X-Greylist: delayed 389 seconds by postgrey-1.32 at olra; Mon, 16 Jan 2012 16:49:33 PST Received: from narco.pvt.stoakes.net (unknown [116.212.217.6]) by olra.theworths.org (Postfix) with ESMTP id D204A431E82 for ; Mon, 16 Jan 2012 16:49:33 -0800 (PST) Received: by narco.pvt.stoakes.net (Postfix, from userid 1000) id 9E110143B79; Tue, 17 Jan 2012 11:13:02 +1030 (CST) Date: Tue, 17 Jan 2012 11:13:02 +1030 From: Tim Stoakes To: Thomas Jost Subject: Re: [PATCH] Add pseudo-compatibility with gmime 2.6 Message-ID: <20120117004302.GB2894@mail.stoakes.net> References: <8762gbtd6p.fsf@schnouki.net> <1326758199-18058-1-git-send-email-schnouki@schnouki.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1326758199-18058-1-git-send-email-schnouki@schnouki.net> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jan 2012 00:49:34 -0000 Thomas Jost(schnouki@schnouki.net)@170112-00:56: > There are lots of API changes in gmime 2.6 crypto handling. By adding > preprocessor directives, it is however possible to add gmime 2.6 compatibility > while preserving compatibility with gmime 2.4 too. > > This is mostly based on id:"8762i8hrb9.fsf@bookbinder.fernseed.info". > > This was tested against both gmime 2.6.4 and 2.4.31. With gmime 2.4.31, the > crypto tests all work fine (as expected). With gmime 2.6.4, one crypto test > fails (signature verification with signer key unavailable) but this will be hard > to fix since the new API does not report the reason why a signature verification > fails (other than the human-readable error message). +1 from me. I literally just coded up a similar patch, and the first email I see with the newly compiled notmuch is this one. I've now tried Thomas's (better) patch with gmime-2.6.4 and notmuch 7ddd849015759a329bf8fef8c8b5a93359408962, and can confirm it works fine for me. This build breakage is otherwise quite painful. Thanks Thomas. Tim -- Tim Stoakes