From: Tim Stoakes <notmuch@stoakes.net>
To: Thomas Jost <schnouki@schnouki.net>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH] Add pseudo-compatibility with gmime 2.6
Date: Tue, 17 Jan 2012 11:13:02 +1030 [thread overview]
Message-ID: <20120117004302.GB2894@mail.stoakes.net> (raw)
In-Reply-To: <1326758199-18058-1-git-send-email-schnouki@schnouki.net>
Thomas Jost(schnouki@schnouki.net)@170112-00:56:
> There are lots of API changes in gmime 2.6 crypto handling. By adding
> preprocessor directives, it is however possible to add gmime 2.6 compatibility
> while preserving compatibility with gmime 2.4 too.
>
> This is mostly based on id:"8762i8hrb9.fsf@bookbinder.fernseed.info".
>
> This was tested against both gmime 2.6.4 and 2.4.31. With gmime 2.4.31, the
> crypto tests all work fine (as expected). With gmime 2.6.4, one crypto test
> fails (signature verification with signer key unavailable) but this will be hard
> to fix since the new API does not report the reason why a signature verification
> fails (other than the human-readable error message).
+1 from me.
I literally just coded up a similar patch, and the first email I see
with the newly compiled notmuch is this one. I've now tried Thomas's
(better) patch with gmime-2.6.4 and notmuch
7ddd849015759a329bf8fef8c8b5a93359408962, and can confirm it works fine
for me. This build breakage is otherwise quite painful.
Thanks Thomas.
Tim
--
Tim Stoakes
next prev parent reply other threads:[~2012-01-17 0:49 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <8762gbtd6p.fsf@schnouki.net>
2012-01-16 23:56 ` [PATCH] Add pseudo-compatibility with gmime 2.6 Thomas Jost
2012-01-17 0:43 ` Tim Stoakes [this message]
2012-01-17 1:08 ` Kazuo Teramoto
2012-01-17 3:47 ` Austin Clements
2012-01-17 10:48 ` Adrian Perez
2012-01-17 10:48 ` Thomas Jost
2012-01-17 10:50 ` [PATCH v2 1/2] show: don't use hex literals in JSON output Thomas Jost
2012-01-17 10:50 ` [PATCH v2 2/2] Add pseudo-compatibility with gmime 2.6 Thomas Jost
2012-01-17 12:48 ` Tomi Ollila
2012-01-17 13:23 ` Thomas Jost
2012-01-17 22:25 ` Austin Clements
2012-01-18 8:15 ` Tomi Ollila
2012-01-18 17:35 ` Austin Clements
2012-01-19 23:33 ` Thomas Jost
2012-01-19 23:32 ` Thomas Jost
2012-01-20 0:06 ` [PATCH v3 0/2] gmime 2.6 compatibilty, 3rd iteration Thomas Jost
2012-01-20 0:06 ` [PATCH v3 1/2] show: don't use hex literals in JSON output Thomas Jost
2012-01-20 0:06 ` [PATCH v3 2/2] Add compatibility with gmime 2.6 Thomas Jost
2012-01-20 4:10 ` Austin Clements
2012-01-20 9:37 ` Thomas Jost
2012-01-20 9:39 ` [PATCH v4 1/3] show: don't use hex literals in JSON output Thomas Jost
2012-01-20 9:39 ` [PATCH v4 2/3] Add compatibility with gmime 2.6 Thomas Jost
2012-01-20 16:33 ` Austin Clements
2012-01-20 22:45 ` Tomi Ollila
2012-01-21 13:10 ` David Bremner
2012-01-20 9:39 ` [PATCH v4 3/3] Update NEWS and INSTALL about " Thomas Jost
2012-01-20 16:39 ` Austin Clements
2012-01-22 0:29 ` [PATCH] Fix NEWS " Thomas Jost
2012-01-22 12:55 ` David Bremner
2012-01-21 13:11 ` [PATCH v4 3/3] Update NEWS and INSTALL " David Bremner
2012-01-20 11:55 ` [PATCH v4 1/3] show: don't use hex literals in JSON output David Bremner
2012-01-20 12:33 ` Thomas Jost
2012-01-20 13:20 ` David Bremner
2012-01-22 0:20 ` [PATCH] " Thomas Jost
2012-01-22 12:56 ` David Bremner
2012-01-18 17:19 ` [PATCH v2 2/2] Add pseudo-compatibility with gmime 2.6 Tom Prince
2012-01-18 18:00 ` Tomi Ollila
2012-01-19 23:47 ` Thomas Jost
2012-01-17 20:38 ` [PATCH] " Austin Clements
2012-01-19 23:52 ` Thomas Jost
2012-01-20 13:32 ` Tomi Ollila
2012-01-17 10:19 ` Adrian Perez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120117004302.GB2894@mail.stoakes.net \
--to=notmuch@stoakes.net \
--cc=notmuch@notmuchmail.org \
--cc=schnouki@schnouki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).