From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 320D8429E47 for ; Fri, 13 Jan 2012 14:54:55 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CAYIdw8fZxIR for ; Fri, 13 Jan 2012 14:54:54 -0800 (PST) Received: from dmz-mailsec-scanner-8.mit.edu (DMZ-MAILSEC-SCANNER-8.MIT.EDU [18.7.68.37]) by olra.theworths.org (Postfix) with ESMTP id 95A87429E3F for ; Fri, 13 Jan 2012 14:54:54 -0800 (PST) X-AuditID: 12074425-b7f4a6d0000008e0-5f-4f10b63d784b Received: from mailhub-auth-3.mit.edu ( [18.9.21.43]) by dmz-mailsec-scanner-8.mit.edu (Symantec Messaging Gateway) with SMTP id FC.32.02272.D36B01F4; Fri, 13 Jan 2012 17:54:54 -0500 (EST) Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id q0DMsrnc007316; Fri, 13 Jan 2012 17:54:53 -0500 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) (authenticated bits=0) (User authenticated as amdragon@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q0DMspwZ026059 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Fri, 13 Jan 2012 17:54:52 -0500 (EST) Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) (envelope-from ) id 1Rlq1L-00009w-BT; Fri, 13 Jan 2012 17:54:51 -0500 Date: Fri, 13 Jan 2012 17:54:51 -0500 From: Austin Clements To: Xavier Maillard Subject: Re: [PATCH] Set fill column to 70 in .dir-locals.el and refactor other settings. Message-ID: <20120113225451.GK18625@mit.edu> References: <1326410243-22277-1-git-send-email-amdragon@mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjleLIzCtJLcpLzFFi42IR4hTV1rXbJuBv0HWR0eL6zZnMFo/a97M7 MHm0TTPzeLbqFnMAUxSXTUpqTmZZapG+XQJXxubvfxkLXvNVTNz8i6mB8QJ3FyMnh4SAicT5 Q2+YIGwxiQv31rN1MXJxCAnsY5R43reMEcLZwCixbeMeqMxJJomdEw6xQjhLGCUmzXkI5HBw sAioSpy7wQcyik1AQ2Lb/uWMILaIgKLEgU372EBsZgFpiW+/m5lAyoUFoiW6tmmDhHkFdCRe vLzEDDFyGqPE3P09LBAJQYmTM5+wQPRqSdz49xKsF2TO8n8cIGFOAVOJb+sOgI0XFVCRmHJy G9sERqFZSLpnIemehdC9gJF5FaNsSm6Vbm5iZk5xarJucXJiXl5qka6FXm5miV5qSukmRlBQ s7uo7mCccEjpEKMAB6MSD69kloC/EGtiWXFl7iFGSQ4mJVFelq1AIb6k/JTKjMTijPii0pzU 4kOMEhzMSiK8UqZAOd6UxMqq1KJ8mJQ0B4uSOK+m1js/IYH0xJLU7NTUgtQimKwMB4eSBO9O kKGCRanpqRVpmTklCGkmDk6Q4TxAw7eA1PAWFyTmFmemQ+RPMepynFx75RyjEEtefl6qlDhv G0iRAEhRRmke3BxYMnrFKA70ljBvJUgVDzCRwU16BbSECWhJWQofyJKSRISUVAPjspqYmf+m pnw+8Cg2WHHitEOz+eJUnlxc4CCl9VJo0cZtjRt7Tcs/f77l+vjCTR/TOU1hD6xfBgkd6voy 7feh6T29P0/dfbqxqWoPMKw/G9/ckJireGNuZKvD6VKXj08zd6Vc2apm++PKvD8B2z/es5ht O6Fa79a0BKlVblNiS6MlnI+su1pirsRSnJFoqMVcVJwIAKkjO+whAwAA Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jan 2012 22:54:55 -0000 Quoth Xavier Maillard on Jan 13 at 11:42 pm: > > This controls where comments and other text wraps. 70 is the default > value, so this simply returns it to the default for people who have > overridden it. Most notmuch code already adheres to this. > --- > SO here is the patch (still sorry if I did it wrongly and very badly). > > .dir-locals.el | 19 ++++++------------- > 1 files changed, 6 insertions(+), 13 deletions(-) > > diff --git a/.dir-locals.el b/.dir-locals.el > index aea630b..27f01c0 100644 > --- a/.dir-locals.el > +++ b/.dir-locals.el > @@ -1,23 +1,16 @@ > -; emacs local configuration settings for notmuch source > -; surmised by dkg on 2010-11-23 13:43:18-0500 > -; amended by amdragon on 2011-06-06 > +;; emacs local configuration settings for notmuch source > +;; surmised by dkg on 2010-11-23 13:43:18-0500 > +;; amended by amdragon on 2011-06-06 > > -((c-mode > +((nil > (indent-tabs-mode . t) > (tab-width . 8) > (c-basic-offset . 4) > + (fill-column . 70)) > + (c-mode > (c-file-style . "linux")) > (c++-mode > - (indent-tabs-mode . t) > - (tab-width . 8) > - (c-basic-offset . 4) > (c-file-style . "linux")) > - (emacs-lisp-mode > - (indent-tabs-mode . t) > - (tab-width . 8)) > (shell-mode > - (indent-tabs-mode . t) > - (tab-width . 8) > - (sh-basic-offset . 4) > (sh-indentation . 4)) > ) You ammended it right, but actually the configuration is intentionally repeated for the various modes. For some programming languages (notably Python), it's inappropriate to mess with the tab settings (especially indent-tabs-mode), hence I took a "whitelist" approach to be on the safe side, rather than using global settings and then enumerating the modes I happened to know would break. This is admittedly subtle. There should probably be a comment in the file explaining this.