From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id D4928429E29 for ; Wed, 11 Jan 2012 19:57:37 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dcwebr+Y6lhz for ; Wed, 11 Jan 2012 19:57:37 -0800 (PST) Received: from dmz-mailsec-scanner-6.mit.edu (DMZ-MAILSEC-SCANNER-6.MIT.EDU [18.7.68.35]) by olra.theworths.org (Postfix) with ESMTP id 5E15C429E25 for ; Wed, 11 Jan 2012 19:57:37 -0800 (PST) X-AuditID: 12074423-b7f9c6d0000008c3-e9-4f0e5a309d62 Received: from mailhub-auth-1.mit.edu ( [18.9.21.35]) by dmz-mailsec-scanner-6.mit.edu (Symantec Messaging Gateway) with SMTP id 9D.64.02243.03A5E0F4; Wed, 11 Jan 2012 22:57:36 -0500 (EST) Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id q0C3vZpc030544; Wed, 11 Jan 2012 22:57:35 -0500 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) (authenticated bits=0) (User authenticated as amdragon@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q0C3vYvS015394 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Wed, 11 Jan 2012 22:57:35 -0500 (EST) Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) (envelope-from ) id 1RlBnH-0004ju-Fv; Wed, 11 Jan 2012 22:57:39 -0500 Date: Wed, 11 Jan 2012 22:57:39 -0500 From: Austin Clements To: David Bremner Subject: Re: [PATCH 2/2] notmuch-reply.c: uncrustify Message-ID: <20120112035739.GW20796@mit.edu> References: <1324135695-15487-1-git-send-email-david@tethera.net> <1326197228-10356-1-git-send-email-david@tethera.net> <1326197228-10356-3-git-send-email-david@tethera.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1326197228-10356-3-git-send-email-david@tethera.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplleLIzCtJLcpLzFFi42IR4hRV1jWI4vM3WNGnbbFx2U9mixut3YwW 12/OZHZg9vjVNpfZ49mqW8weWw69Zw5gjuKySUnNySxLLdK3S+DK2PO3galgI3vF/jcHWBoY n7B2MXJySAiYSOzf08UMYYtJXLi3nq2LkYtDSGAfo0T7mmVMIAkhgQ2MEi2dUhD2SSaJC1MD IYqWMErM61sGNolFQFVi2rVdYA1sAhoS2/YvZwSxRYDiV7dNZgOxmQXsJRbNnsQOYgsDbX69 8SbYZl4BHYmrnd9YIIZuZJTo3bGVDSIhKHFy5hMWiGYtiRv/XgIt4ACypSWW/+MACXMKOEks v3ge7AZRARWJKSe3sU1gFJqFpHsWku5ZCN0LGJlXMcqm5Fbp5iZm5hSnJusWJyfm5aUW6Zrp 5WaW6KWmlG5iBIU6u4vyDsY/B5UOMQpwMCrx8O7Yy+svxJpYVlyZe4hRkoNJSZT3RjifvxBf Un5KZUZicUZ8UWlOavEhRgkOZiURXqcaoHLelMTKqtSifJiUNAeLkjivhtY7PyGB9MSS1OzU 1ILUIpisDAeHkgTvp0igoYJFqempFWmZOSUIaSYOTpDhPEDDH4HU8BYXJOYWZ6ZD5E8xKkqJ 8x4ESQiAJDJK8+B6YanoFaM40CvCvHtAqniAaQyu+xXQYCagwVvW8YAMLklESEk1MHr93/Fp /fbXFtvqKiXjFleXnhdVLp0R6HGjXeXwAy/VrsotT1l6s769ELCY/D7wPteF9P4FD9WPWsT4 qjRcdupZELmjx0P85PTuF73b9LqimDLkG87eKti+8EemG+ttgT8Mn/Le3PRnNj5tfkmp4ops eveNknOb5V/HdsfM+d/86dzV2OM5/kosxRmJhlrMRcWJAC+Vv7YgAwAA Cc: notmuch@notmuchmail.org, David Bremner X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jan 2012 03:57:38 -0000 Quoth David Bremner on Jan 10 at 8:07 am: > From: David Bremner > > This patch shows the raw result of running uncrustify on notmuch-reply.c. > The re-indenting of "format_reply" would probably not be desirable. The good news is that that structure is on its way out. > @@ -625,6 +612,7 @@ notmuch_reply_command (void *ctx, int argc, char *argv[]) > notmuch_query_t *query; > char *query_string; > int opt_index, ret = 0; > + This one's a little weird. Did it get confused by the function prototype? > int (*reply_format_func)(void *ctx, notmuch_config_t *config, notmuch_query_t *query, notmuch_show_params_t *params); > notmuch_show_params_t params = { .part = -1 }; > int format = FORMAT_DEFAULT; All of the other format fixes look very reasonable to me. I think you managed to find one of the least canonical source files in the tree. Was that intentional?