From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 31C2240F208 for ; Sat, 7 Jan 2012 16:26:04 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id n6MsAI2QYVxS for ; Sat, 7 Jan 2012 16:26:03 -0800 (PST) Received: from dmz-mailsec-scanner-7.mit.edu (DMZ-MAILSEC-SCANNER-7.MIT.EDU [18.7.68.36]) by olra.theworths.org (Postfix) with ESMTP id 8CAF840A620 for ; Sat, 7 Jan 2012 16:26:03 -0800 (PST) X-AuditID: 12074424-b7fae6d000000906-17-4f08e29bf525 Received: from mailhub-auth-1.mit.edu ( [18.9.21.35]) by dmz-mailsec-scanner-7.mit.edu (Symantec Messaging Gateway) with SMTP id 85.6C.02310.B92E80F4; Sat, 7 Jan 2012 19:26:03 -0500 (EST) Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id q080Q2nd028361; Sat, 7 Jan 2012 19:26:02 -0500 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) (authenticated bits=0) (User authenticated as amdragon@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q080Q10p025864 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Sat, 7 Jan 2012 19:26:01 -0500 (EST) Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) (envelope-from ) id 1RjgaY-0003tk-8e; Sat, 07 Jan 2012 19:26:18 -0500 Date: Sat, 7 Jan 2012 19:26:18 -0500 From: Austin Clements To: Jani Nikula Subject: Re: [RFC PATCH 3/9] lib: fix messages.c build warn Message-ID: <20120108002618.GA27250@mit.edu> References: <6d465c52d6ce9deef079c74389d810f944801bee.1325977940.git.jani@nikula.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6d465c52d6ce9deef079c74389d810f944801bee.1325977940.git.jani@nikula.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprBKsWRmVeSWpSXmKPExsUixCmqrDv7EYe/wb/pbBZN050trt+cyezA 5HHr/mt2j2erbjEHMEVx2aSk5mSWpRbp2yVwZWy8klGwnaPi/oJTLA2MH9i6GDk5JARMJF4/ PcMOYYtJXLi3HijOxSEksI9R4sTmtYwQznpGidUzXrBAOCeYJK4vuMwC0iIksIRRYsIzoS5G Dg4WARWJA20BIGE2AQ2JbfuXM4LYIgKKEptP7gezmQWkJb79bmYCsYUFrCUer3vNDGLzCuhI PHrSwQ4xsk5iwpXv7BBxQYmTM5+wQPSqS/yZd4kZZBXInOX/OCDC8hLNW2eDjeEUCJN4+uEl 2GOiQNdMObmNbQKj8Cwkk2YhmTQLYdIsJJMWMLKsYpRNya3SzU3MzClOTdYtTk7My0st0jXX y80s0UtNKd3ECIoAdheVHYzNh5QOMQpwMCrx8L7SYvcXYk0sK67MPcQoycGkJMqbep/DX4gv KT+lMiOxOCO+qDQntfgQowQHs5IIb+lNoBxvSmJlVWpRPkxKmoNFSZxXQ+udn5BAemJJanZq akFqEUxWhoNDSYLXAhjpQoJFqempFWmZOSUIaSYOTpDhPEDDv9wFGV5ckJhbnJkOkT/FqCgl zusK0iwAksgozYPrhSWoV4ziQK8I82qBVPEAkxtc9yugwUxAgx/8YQcZXJKIkJJqYNx9rPfW mc1b5nZbpQiwzO6RnN7kcP/MGd1WsX75M82eic9k2Mun7q8v/ME49f+X506zcmdcTTRi/m32 oUHgSeQjQ0buZar/16utSMm6qpN+84OZnBzXLsvyQ0skcnnmK2ukrXmXv8SDgVVRyv7S1OCD zE2qZ7U+2k0q3h2S2zxzCYfZ5PCD95RYijMSDbWYi4oTAU7PoSwrAwAA Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Jan 2012 00:26:04 -0000 I don't have much opinion on the other patches in this series (the C99 variadic macro stuff is unfortunate), but this one should go in. Quoth Jani Nikula on Jan 08 at 1:26 am: > lib/messages.c: In function ‘notmuch_messages_move_to_next’: > lib/messages.c:131:2: warning: ISO C forbids ‘return’ with expression, in function returning void [-pedantic] > > Signed-off-by: Jani Nikula > --- > lib/messages.c | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/lib/messages.c b/lib/messages.c > index 7bcd1ab..1121864 100644 > --- a/lib/messages.c > +++ b/lib/messages.c > @@ -127,8 +127,10 @@ notmuch_messages_get (notmuch_messages_t *messages) > void > notmuch_messages_move_to_next (notmuch_messages_t *messages) > { > - if (! messages->is_of_list_type) > - return _notmuch_mset_messages_move_to_next (messages); > + if (! messages->is_of_list_type) { > + _notmuch_mset_messages_move_to_next (messages); > + return; > + } > > if (messages->iterator == NULL) > return;