unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Austin Clements <amdragon@MIT.EDU>
To: Jani Nikula <jani@nikula.org>
Cc: notmuch@notmuchmail.org
Subject: Re: [RFC PATCH 3/9] lib: fix messages.c build warn
Date: Sat, 7 Jan 2012 19:26:18 -0500	[thread overview]
Message-ID: <20120108002618.GA27250@mit.edu> (raw)
In-Reply-To: <6d465c52d6ce9deef079c74389d810f944801bee.1325977940.git.jani@nikula.org>

I don't have much opinion on the other patches in this series (the C99
variadic macro stuff is unfortunate), but this one should go in.

Quoth Jani Nikula on Jan 08 at  1:26 am:
> lib/messages.c: In function ‘notmuch_messages_move_to_next’:
> lib/messages.c:131:2: warning: ISO C forbids ‘return’ with expression, in function returning void [-pedantic]
> 
> Signed-off-by: Jani Nikula <jani@nikula.org>
> ---
>  lib/messages.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/messages.c b/lib/messages.c
> index 7bcd1ab..1121864 100644
> --- a/lib/messages.c
> +++ b/lib/messages.c
> @@ -127,8 +127,10 @@ notmuch_messages_get (notmuch_messages_t *messages)
>  void
>  notmuch_messages_move_to_next (notmuch_messages_t *messages)
>  {
> -    if (! messages->is_of_list_type)
> -	return _notmuch_mset_messages_move_to_next (messages);
> +    if (! messages->is_of_list_type) {
> +	_notmuch_mset_messages_move_to_next (messages);
> +	return;
> +    }
>  
>      if (messages->iterator == NULL)
>  	return;

  reply	other threads:[~2012-01-08  0:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-07 23:26 [RFC PATCH 0/9] -std=c99 / -std=c++0x -pedantic Jani Nikula
2012-01-07 23:26 ` [RFC PATCH 1/9] build: use -std=c99 -pedantic for C source Jani Nikula
2012-01-07 23:26 ` [RFC PATCH 2/9] xutil: #define _POSIX_C_SOURCE to get strdup() Jani Nikula
2012-01-07 23:26 ` [RFC PATCH 3/9] lib: fix messages.c build warn Jani Nikula
2012-01-08  0:26   ` Austin Clements [this message]
2012-01-10 10:38   ` David Bremner
2012-01-07 23:26 ` [RFC PATCH 4/9] lib: HACK: avoid warnings from talloc_steal() Jani Nikula
2012-01-07 23:26 ` [RFC PATCH 5/9] cli: fix warning about variadic macros Jani Nikula
2012-01-07 23:26 ` [RFC PATCH 6/9] cli: fix another " Jani Nikula
2012-01-07 23:26 ` [RFC PATCH 7/9] util: fix " Jani Nikula
2012-01-07 23:26 ` [RFC PATCH 8/9] lib: use -std=c++0x -pedantic Jani Nikula
2012-01-07 23:26 ` [RFC PATCH 9/9] test: smtp-dummy: fixes for -std=c99 -pedantic Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120108002618.GA27250@mit.edu \
    --to=amdragon@mit.edu \
    --cc=jani@nikula.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).