From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 36C86431FD0 for ; Fri, 30 Dec 2011 19:07:21 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Amavis-Alert: BAD HEADER SECTION, Duplicate header field: "Date" X-Spam-Flag: NO X-Spam-Score: -0.367 X-Spam-Level: X-Spam-Status: No, score=-0.367 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, INVALID_DATE=0.432, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TR65sSMoy-TT for ; Fri, 30 Dec 2011 19:07:20 -0800 (PST) Received: from mail-qy0-f181.google.com (mail-qy0-f181.google.com [209.85.216.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id A1339431FB6 for ; Fri, 30 Dec 2011 19:07:20 -0800 (PST) Received: by qcha6 with SMTP id a6so11090014qch.26 for ; Fri, 30 Dec 2011 19:07:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=content-type:mime-version:content-transfer-encoding:from:to :references:in-reply-to:date:message-id:subject:date; bh=/oojh9RnGEdvpd5r/WPstPbhEzE2wHjgUlykd2L4+xE=; b=AfTKyY4vzFIhjieq/ogEUFSvKzPLs9jrqETzCyriTbpp3I4gTG7nRf/h1XeBpV1OrD 7rUlBY7advhfXAJ3P4+hOiDIE4EUHKvp//fmJ6NS6Ea+gfmVnrVj/m/lN37oWRLHxk/m qI89xa9VeowaUaHF8VKgGpRXubniwEVgzEJoI= Received: by 10.229.76.142 with SMTP id c14mr15081880qck.132.1325300840026; Fri, 30 Dec 2011 19:07:20 -0800 (PST) Received: from localhost (201-1-35-143.dsl.telesp.net.br. [201.1.35.143]) by mx.google.com with ESMTPS id fe5sm50863465qab.5.2011.12.30.19.07.18 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 30 Dec 2011 19:07:19 -0800 (PST) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Kazuo Teramoto To: David Bremner , notmuch@notmuchmail.org References: <877h1e6r9d.fsf@zancas.localnet> <1325282290-29565-1-git-send-email-kaz.rag@gmail.com> <1325282290-29565-2-git-send-email-kaz.rag@gmail.com> <87k45d5u0w.fsf@zancas.localnet> In-Reply-To: <87k45d5u0w.fsf@zancas.localnet> Date: Sat, 31 Dec 2011 03:07:16 -0000 Message-ID: <20111231030716.792.79379@sophie> Subject: Re: [PATCH 1/2] lib: Remove unnecessary checks when calling g_mime_init Date: Sat, 31 Dec 2011 01:07:16 -0200 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Dec 2011 03:07:21 -0000 On 2011-12-31T00:55:59, David Bremner wrote: >On Fri, 30 Dec 2011 19:58:09 -0200, Kazuo Teramoto wro= te: >> g_mime_init already check for multiple initializations. >> --- >> lib/index.cc | 4 ---- >> lib/message-file.c | 4 ---- >> 2 files changed, 0 insertions(+), 8 deletions(-) > >Is this needed to fix the bug? It seems less futureproof to rely on >gmime to check for double initialization if we don't have to. > No its not. But if you decide to push only the other part we probably need to add the initialization check to it, for consistency. I can send another patch, would you like it?