unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Kazuo Teramoto <kaz.rag@gmail.com>
To: Patrick Totzke <patricktotzke@googlemail.com>,
	notmuch@notmuchmail.org, David Bremner <david@tethera.net>
Subject: Re: [PATCH 0/2] Multiples calls of g_mime_init
Date: Sat, 31 Dec 2011 01:30:28 -0000
Date: Fri, 30 Dec 2011 23:30:28 -0200	[thread overview]
Message-ID: <20111231013028.14545.79903@sophie> (raw)
In-Reply-To: <20111231011647.24112.70437@brick.lan>

On 2011-12-30T23:16:47, Patrick Totzke wrote:

>It seeminly doesn't break things either and I'm all in favour of doing
>things right™.

And talking about doing things right, we probably need to call
g_mime_shutdown() too, one for every time we call g_mime_init(). I will
send a patch after I do some more tests.

>On a related note: It also doesn't fix the recent segfaults of the bindings
>that occur when you try to write to a locked database.
>cf "id:4eddf2b1.4288980a.0b74.5557@mx.google.com"
>

This still hit me. If I remember right when I did a test what is
happening is that the binding is trying to close the db, so we need a
check if the db is opened before trying to close it.

  reply	other threads:[~2011-12-31  1:30 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-30  0:57 Segmentation fault at gmime-iconv with python binding Kazuo Teramoto
2011-12-30 14:58 ` David Bremner
2011-12-30 21:58   ` [PATCH 0/2] Multiples calls of g_mime_init Kazuo Teramoto
2011-12-30 21:58     ` [PATCH 1/2] lib: Remove unnecessary checks when calling g_mime_init Kazuo Teramoto
2011-12-31  2:55       ` David Bremner
2011-12-31  3:07         ` Kazuo Teramoto
2011-12-31  4:45       ` Austin Clements
2012-01-21 13:25       ` David Bremner
2012-01-21 13:32         ` Kazuo Teramoto
2011-12-30 21:58     ` [PATCH 2/2] lib: call g_mime_init from notmuch_database_open Kazuo Teramoto
2011-12-31  3:02       ` David Bremner
2011-12-31  4:37         ` [PATCH] lib: call g_mime_init() from notmuch_database_open() Kazuo Teramoto
2011-12-31  4:37           ` Kazuo Teramoto
2012-01-01  3:22             ` revised patch for gmime init, with test David Bremner
2012-01-01  3:22               ` [PATCH v2 1/3] test: use file based comparison for search '*' test David Bremner
2012-01-01  3:22               ` [PATCH v2 2/3] test: add two new messages to corpus with iso-8859-1 encoding David Bremner
2012-01-01  3:22               ` [PATCH v2 3/3] lib: call g_mime_init() from notmuch_database_open() David Bremner
2012-01-12 17:25               ` revised patch for gmime init, with test Pieter Praet
2012-01-13  3:46                 ` David Bremner
2012-01-13  9:05                   ` David Bremner
2012-01-13 20:52                     ` Jameson Graef Rollins
2012-01-14  1:31                       ` David Bremner
2012-01-14  8:54                     ` Pieter Praet
2012-01-14  8:51                   ` Pieter Praet
2012-01-02 12:56         ` [PATCH 2/2] lib: call g_mime_init from notmuch_database_open Tomi Ollila
2011-12-31  1:16     ` [PATCH 0/2] Multiples calls of g_mime_init Patrick Totzke
2011-12-31  1:30       ` Kazuo Teramoto [this message]
2012-01-02 15:43   ` Segmentation fault at gmime-iconv with python binding Sebastian Spaeth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111231013028.14545.79903@sophie \
    --to=kaz.rag@gmail.com \
    --cc=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    --cc=patricktotzke@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).