From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id EF969431FD0 for ; Wed, 28 Dec 2011 12:35:31 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RGVGwd8WxO98 for ; Wed, 28 Dec 2011 12:35:31 -0800 (PST) Received: from dmz-mailsec-scanner-8.mit.edu (DMZ-MAILSEC-SCANNER-8.MIT.EDU [18.7.68.37]) by olra.theworths.org (Postfix) with ESMTP id 14ED0431FB6 for ; Wed, 28 Dec 2011 12:35:31 -0800 (PST) X-AuditID: 12074425-b7f4a6d0000008e0-e6-4efb7d92312a Received: from mailhub-auth-4.mit.edu ( [18.7.62.39]) by dmz-mailsec-scanner-8.mit.edu (Symantec Messaging Gateway) with SMTP id 74.A6.02272.29D7BFE4; Wed, 28 Dec 2011 15:35:30 -0500 (EST) Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id pBSKZTFw017121; Wed, 28 Dec 2011 15:35:30 -0500 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) (authenticated bits=0) (User authenticated as amdragon@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id pBSKZSWX013232 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Wed, 28 Dec 2011 15:35:29 -0500 (EST) Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) (envelope-from ) id 1Rg0ER-0002uO-QD; Wed, 28 Dec 2011 15:36:15 -0500 Date: Wed, 28 Dec 2011 15:36:15 -0500 From: Austin Clements To: Jameson Graef Rollins Subject: Re: [PATCH v2] Ignore encrypted parts when indexing. Message-ID: <20111228203615.GE30150@mit.edu> References: <1325005901-21374-1-git-send-email-jrollins@finestructure.net> <1325103269-14599-1-git-send-email-jrollins@finestructure.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1325103269-14599-1-git-send-email-jrollins@finestructure.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpgleLIzCtJLcpLzFFi42IRYrdT151U+9vP4MEjRYs9+7wsrt+cyezA 5HH3NJfHs1W3mAOYorhsUlJzMstSi/TtErgyNkz4yF6whKPizEW/BsZNbF2MnBwSAiYS/W2r GSFsMYkL99aDxYUE9jFKfH5Z2sXIBWRvYJT4/XgHG4Rzkkmi5eRVKGcJo0TruV6mLkYODhYB VYlvf4NButkENCS27V8ONlVEwEyi58sfMJtZQEti68YPYLawgK3EgfUtTCA2r4COxLe9j1kh ZnYzSuzbu4EdIiEocXLmExaY5hv/XoLtYhaQllj+jwMkzCngLdH/fS/Y1aICKhJTTm5jm8Ao NAtJ9ywk3bMQuhcwMq9ilE3JrdLNTczMKU5N1i1OTszLSy3StdDLzSzRS00p3cQIDmgX1R2M Ew4pHWIU4GBU4uH1NPztJ8SaWFZcmXuIUZKDSUmU9145UIgvKT+lMiOxOCO+qDQntfgQowQH s5II74JKoBxvSmJlVWpRPkxKmoNFSZxXU+udn5BAemJJanZqakFqEUxWhoNDSYL3Sg1Qo2BR anpqRVpmTglCmomDE2Q4D9DwzSA1vMUFibnFmekQ+VOMilLivKdBEgIgiYzSPLheWMJ5xSgO 9Iow73aQKh5gsoLrfgU0mAlo8Llzv0AGlyQipKQaGCvKp+0NfRW/g5FVfZFg3IroM6c4zQo3 y7WqixT5/Lq+PVC21PuGTkcWh+Ksz2Yzf8+v3+jVV9Jm1tSnv3d6WmzWNs0Lyy1n/fvS9Da8 4UdeTaR1RPS5/EA/kdWlMZ1zff5YiG/628l94lHva7G9M7RKr15uus5y4OlRw0jlyE/isWJs gSxblViKMxINtZiLihMBCOVskxMDAAA= Cc: Notmuch Mail X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Dec 2011 20:35:32 -0000 LGTM. Quoth Jameson Graef Rollins on Dec 28 at 12:14 pm: > It appears to be an oversight that encrypted parts were indexed > previously. The terms generated from encrypted parts are meaningless > and do nothing but add bloat to the database. It is not worth > indexing the encrypted content, just as it's not worth indexing the > signatures in signed parts. > --- > Fixes missing colon. Thanks Austin, Xavier. > > lib/index.cc | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/lib/index.cc b/lib/index.cc > index e8e9922..d8f8b2b 100644 > --- a/lib/index.cc > +++ b/lib/index.cc > @@ -339,6 +339,10 @@ _index_mime_part (notmuch_message_t *message, > if (i > 1) > fprintf (stderr, "Warning: Unexpected extra parts of multipart/signed. Indexing anyway.\n"); > } > + if (GMIME_IS_MULTIPART_ENCRYPTED (multipart)) { > + /* Don't index encrypted parts. */ > + continue; > + } > _index_mime_part (message, > g_mime_multipart_get_part (multipart, i)); > }