[PATCH] Ignore encrypted parts when indexing.

[PATCH] Ignore encrypted parts when indexing.

[Jameson Graef Rollins]

It appears to be an oversight that encrypted parts were indexed
previously.  The terms generated from encrypted parts are meaningless
and do nothing but add bloat to the database.  It is not worth
indexing the encrypted content, just as it's not worth indexing the
signatures in signed parts.
---
 lib/index.cc |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/lib/index.cc b/lib/index.cc
index e8e9922..0cff9cd 100644
--- a/lib/index.cc
+++ b/lib/index.cc
@@ -339,6 +339,10 @@ _index_mime_part (notmuch_message_t *message,
 		if (i > 1)
 		    fprintf (stderr, "Warning: Unexpected extra parts of multipart/signed. Indexing anyway.\n");
 	    }
+	    if (GMIME_IS_MULTIPART_ENCRYPTED (multipart)) {
+		/* Don't index encrypted parts. */
+		continue
+	    }
 	    _index_mime_part (message,
 			      g_mime_multipart_get_part (multipart, i));
 	}
-- 
1.7.7.3

Re: [PATCH] Ignore encrypted parts when indexing.

[Austin Clements]

Quoth Jameson Graef Rollins on Dec 27 at  9:11 am:
> It appears to be an oversight that encrypted parts were indexed
> previously.  The terms generated from encrypted parts are meaningless
> and do nothing but add bloat to the database.  It is not worth
> indexing the encrypted content, just as it's not worth indexing the
> signatures in signed parts.
> ---
>  lib/index.cc |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/lib/index.cc b/lib/index.cc
> index e8e9922..0cff9cd 100644
> --- a/lib/index.cc
> +++ b/lib/index.cc
> @@ -339,6 +339,10 @@ _index_mime_part (notmuch_message_t *message,
>  		if (i > 1)
>  		    fprintf (stderr, "Warning: Unexpected extra parts of multipart/signed. Indexing anyway.\n");
>  	    }
> +	    if (GMIME_IS_MULTIPART_ENCRYPTED (multipart)) {
> +		/* Don't index encrypted parts. */
> +		continue

Uh.  Semicolon?

> +	    }
>  	    _index_mime_part (message,
>  			      g_mime_multipart_get_part (multipart, i));
>  	}

Re: [PATCH] Ignore encrypted parts when indexing.

[Xavier Maillard]

Hi Jameson,

On Tue, 27 Dec 2011 09:11:41 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> It appears to be an oversight that encrypted parts were indexed
> previously.  The terms generated from encrypted parts are meaningless
> and do nothing but add bloat to the database.  It is not worth
> indexing the encrypted content, just as it's not worth indexing the
> signatures in signed parts.

+1 for this.

But,

> +	    if (GMIME_IS_MULTIPART_ENCRYPTED (multipart)) {
> +		/* Don't index encrypted parts. */
> +		continue

This needs a semicolon, doesn't it ?

/Xavier

[PATCH v2] Ignore encrypted parts when indexing.

[Jameson Graef Rollins]

It appears to be an oversight that encrypted parts were indexed
previously.  The terms generated from encrypted parts are meaningless
and do nothing but add bloat to the database.  It is not worth
indexing the encrypted content, just as it's not worth indexing the
signatures in signed parts.
---
Fixes missing colon.  Thanks Austin, Xavier.

 lib/index.cc |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/lib/index.cc b/lib/index.cc
index e8e9922..d8f8b2b 100644
--- a/lib/index.cc
+++ b/lib/index.cc
@@ -339,6 +339,10 @@ _index_mime_part (notmuch_message_t *message,
 		if (i > 1)
 		    fprintf (stderr, "Warning: Unexpected extra parts of multipart/signed. Indexing anyway.\n");
 	    }
+	    if (GMIME_IS_MULTIPART_ENCRYPTED (multipart)) {
+		/* Don't index encrypted parts. */
+		continue;
+	    }
 	    _index_mime_part (message,
 			      g_mime_multipart_get_part (multipart, i));
 	}
-- 
1.7.7.3

Re: [PATCH v2] Ignore encrypted parts when indexing.

[Austin Clements]

LGTM.

Quoth Jameson Graef Rollins on Dec 28 at 12:14 pm:
> It appears to be an oversight that encrypted parts were indexed
> previously.  The terms generated from encrypted parts are meaningless
> and do nothing but add bloat to the database.  It is not worth
> indexing the encrypted content, just as it's not worth indexing the
> signatures in signed parts.
> ---
> Fixes missing colon.  Thanks Austin, Xavier.
> 
>  lib/index.cc |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/lib/index.cc b/lib/index.cc
> index e8e9922..d8f8b2b 100644
> --- a/lib/index.cc
> +++ b/lib/index.cc
> @@ -339,6 +339,10 @@ _index_mime_part (notmuch_message_t *message,
>  		if (i > 1)
>  		    fprintf (stderr, "Warning: Unexpected extra parts of multipart/signed. Indexing anyway.\n");
>  	    }
> +	    if (GMIME_IS_MULTIPART_ENCRYPTED (multipart)) {
> +		/* Don't index encrypted parts. */
> +		continue;
> +	    }
>  	    _index_mime_part (message,
>  			      g_mime_multipart_get_part (multipart, i));
>  	}

Re: [PATCH v2] Ignore encrypted parts when indexing.

[Tomi Ollila]

On Wed, 28 Dec 2011 12:14:29 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> It appears to be an oversight that encrypted parts were indexed
> previously.  The terms generated from encrypted parts are meaningless
> and do nothing but add bloat to the database.  It is not worth
> indexing the encrypted content, just as it's not worth indexing the
> signatures in signed parts.
> ---

LGTM.

Tomi

Re: [PATCH v2] Ignore encrypted parts when indexing.

[David Bremner]

On Wed, 28 Dec 2011 12:14:29 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> It appears to be an oversight that encrypted parts were indexed
> previously.  The terms generated from encrypted parts are meaningless
> and do nothing but add bloat to the database.  It is not worth
> indexing the encrypted content, just as it's not worth indexing the
> signatures in signed parts.

Pushed.

d