From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id E9A98431FD0 for ; Tue, 27 Dec 2011 19:31:12 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id U0logqQvbRkQ for ; Tue, 27 Dec 2011 19:31:10 -0800 (PST) Received: from dmz-mailsec-scanner-6.mit.edu (DMZ-MAILSEC-SCANNER-6.MIT.EDU [18.7.68.35]) by olra.theworths.org (Postfix) with ESMTP id 9D9CB431FB6 for ; Tue, 27 Dec 2011 19:31:10 -0800 (PST) X-AuditID: 12074423-b7f9c6d0000008c3-a2-4efa8d7e832d Received: from mailhub-auth-2.mit.edu ( [18.7.62.36]) by dmz-mailsec-scanner-6.mit.edu (Symantec Messaging Gateway) with SMTP id F8.2A.02243.E7D8AFE4; Tue, 27 Dec 2011 22:31:10 -0500 (EST) Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id pBS3V9DC027824; Tue, 27 Dec 2011 22:31:09 -0500 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) (authenticated bits=0) (User authenticated as amdragon@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id pBS3V8YS009831 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Tue, 27 Dec 2011 22:31:09 -0500 (EST) Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) (envelope-from ) id 1RfkFC-0001Qu-4y; Tue, 27 Dec 2011 22:31:58 -0500 Date: Tue, 27 Dec 2011 22:31:58 -0500 From: Austin Clements To: Jameson Graef Rollins Subject: Re: [PATCH] Ignore encrypted parts when indexing. Message-ID: <20111228033158.GC30150@mit.edu> References: <1325005901-21374-1-git-send-email-jrollins@finestructure.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1325005901-21374-1-git-send-email-jrollins@finestructure.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpileLIzCtJLcpLzFFi42IRYrdT0a3r/eVnMHEfn8WefV4W12/OZHZg 8rh7msvj2apbzAFMUVw2Kak5mWWpRfp2CVwZa77PZCv4zV7xZO9mpgbGCWxdjJwcEgImEvfv L2KBsMUkLtxbDxTn4hAS2Mco0XbvCDOEs4FR4tbki0wQzkkmiTv7NkM5Sxglzn87xwjSzyKg KtHQdwxsFpuAhsS2/cvB4iICZhI9X/6A2cwCWhJbN34As4UFrCTeNX5iArF5BXQkDq86CXaT kICXxNyPy1kh4oISJ2c+YYHpvfHvJVA9B5AtLbH8HwdImFPAW+LD2U/MILaogIrElJPb2CYw Cs1C0j0LSfcshO4FjMyrGGVTcqt0cxMzc4pTk3WLkxPz8lKLdM30cjNL9FJTSjcxgoPaRXkH 45+DSocYBTgYlXh4b7796SfEmlhWXJl7iFGSg0lJlNer65efEF9SfkplRmJxRnxRaU5q8SFG CQ5mJRFeywdA5bwpiZVVqUX5MClpDhYlcV4NrXd+QgLpiSWp2ampBalFMFkZDg4lCd7lPUBD BYtS01Mr0jJzShDSTBycIMN5gIYfA6nhLS5IzC3OTIfIn2JUlBLnDQNJCIAkMkrz4HphSecV ozjQK8K8i0CqeIAJC677FdBgJqDBcco/QAaXJCKkpBoYF5g+ENIo8f76tG2W94z1dvXdpRYp 626LGPMaRchNcLl5/w2XNKfLWp3XdVOftQe2nlFq0dj/aK3GhpITm9dqPnh4n029LL9zzv71 9/axym5ctP1EuH9uqE3DJRsR7xsvnaY48/u4W5YV/T7xvfZ4fbKowsWmLc3nz+4R0SvT0tOb Z5wn/+iYEktxRqKhFnNRcSIAosxxxhUDAAA= Cc: Notmuch Mail X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Dec 2011 03:31:13 -0000 Quoth Jameson Graef Rollins on Dec 27 at 9:11 am: > It appears to be an oversight that encrypted parts were indexed > previously. The terms generated from encrypted parts are meaningless > and do nothing but add bloat to the database. It is not worth > indexing the encrypted content, just as it's not worth indexing the > signatures in signed parts. > --- > lib/index.cc | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/lib/index.cc b/lib/index.cc > index e8e9922..0cff9cd 100644 > --- a/lib/index.cc > +++ b/lib/index.cc > @@ -339,6 +339,10 @@ _index_mime_part (notmuch_message_t *message, > if (i > 1) > fprintf (stderr, "Warning: Unexpected extra parts of multipart/signed. Indexing anyway.\n"); > } > + if (GMIME_IS_MULTIPART_ENCRYPTED (multipart)) { > + /* Don't index encrypted parts. */ > + continue Uh. Semicolon? > + } > _index_mime_part (message, > g_mime_multipart_get_part (multipart, i)); > }