From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id DC82C431FD0 for ; Tue, 27 Dec 2011 19:29:14 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 97q9FPo2PChx for ; Tue, 27 Dec 2011 19:29:12 -0800 (PST) Received: from dmz-mailsec-scanner-3.mit.edu (DMZ-MAILSEC-SCANNER-3.MIT.EDU [18.9.25.14]) by olra.theworths.org (Postfix) with ESMTP id B5A1C431FB6 for ; Tue, 27 Dec 2011 19:29:12 -0800 (PST) X-AuditID: 1209190e-b7f7c6d0000008c3-d0-4efa8d0809bc Received: from mailhub-auth-2.mit.edu ( [18.7.62.36]) by dmz-mailsec-scanner-3.mit.edu (Symantec Messaging Gateway) with SMTP id 87.24.02243.80D8AFE4; Tue, 27 Dec 2011 22:29:12 -0500 (EST) Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id pBS3TBDS027702; Tue, 27 Dec 2011 22:29:12 -0500 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) (authenticated bits=0) (User authenticated as amdragon@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id pBS3T8Wr009667 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Tue, 27 Dec 2011 22:29:11 -0500 (EST) Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) (envelope-from ) id 1RfkDF-0001Qb-Iy; Tue, 27 Dec 2011 22:29:57 -0500 Date: Tue, 27 Dec 2011 22:29:57 -0500 From: Austin Clements To: David Edmondson Subject: Re: [PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'. Message-ID: <20111228032957.GB30150@mit.edu> References: <1325004434-24583-1-git-send-email-dme@dme.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1325004434-24583-1-git-send-email-dme@dme.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpmleLIzCtJLcpLzFFi42IRYrdT0eXo/eVn0L9a3GLfnS1MFtdvzmR2 YPLY9fwvk8ezVbeYA5iiuGxSUnMyy1KL9O0SuDK2LvjHUtDOXfH12T2mBsbjHF2MHBwSAiYS x7/odzFyApliEhfurWfrYuTiEBLYxyhxvqWHHcLZwCjx8eNCqMxJJomrS7YwQThLGCUaj59n B+lnEVCVOHf4JjOIzSagIbFt/3JGEFtEQFHi/7cVYDXMAtIS3343M4HYwgJBEuunXgGzeQV0 JK6t7gOzhQSsJaZ9XsMGEReUODnzCQtEr5bEjX8vmUDOBpmz/B8HSJhTwEZi88uvYK2iAioS U05uY5vAKDQLSfcsJN2zELoXMDKvYpRNya3SzU3MzClOTdYtTk7My0st0jXWy80s0UtNKd3E CAprTkm+HYxfDyodYhTgYFTi4b319qefEGtiWXFl7iFGSQ4mJVFer65ffkJ8SfkplRmJxRnx RaU5qcWHGCU4mJVEeC0fAJXzpiRWVqUW5cOkpDlYlMR51bTe+QkJpCeWpGanphakFsFkZTg4 lCR4DXuAhgoWpaanVqRl5pQgpJk4OEGG8wAN9wWp4S0uSMwtzkyHyJ9iVJQS52UBSQiAJDJK 8+B6YWnnFaM40CvCvHogVTzAlAXX/QpoMBPQ4DjlHyCDSxIRUlINjFzZITlZhw5/E7XyOHpy ec4L//dWyk/97OewWd+frvr2F8MP+/nMmtOVnCyjNKY3v9jJXBy2pUur4ZVQddKsDzsDtjMY WtcyNp6t9/rns8xphebrxmPzv7msm7N4mgRnovWslR9Pfm1LvdO+w3HphXXbJs97uO+HhMUN A0vWwOKbM6e4XC+XPqfEUpyRaKjFXFScCAC4kDIeFgMAAA== Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Dec 2011 03:29:15 -0000 LGTM. Quoth David Edmondson on Dec 27 at 4:47 pm: > The tags were coloured using text properties. Unfortunately that text > (the header line) also has an overlay, which overrides the text > properties. There's not point in applying text properties that will > never be seen. > --- > emacs/notmuch-show.el | 8 ++------ > 1 files changed, 2 insertions(+), 6 deletions(-) > > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el > index 8c9d846..24f0b40 100644 > --- a/emacs/notmuch-show.el > +++ b/emacs/notmuch-show.el > @@ -221,10 +221,7 @@ indentation." > (goto-char (notmuch-show-message-top)) > (if (re-search-forward "(\\([^()]*\\))$" (line-end-position) t) > (let ((inhibit-read-only t)) > - (replace-match (concat "(" > - (propertize (mapconcat 'identity tags " ") > - 'face 'notmuch-tag-face) > - ")")))))) > + (replace-match (concat "(" (mapconcat 'identity tags " ") ")")))))) > > (defun notmuch-show-clean-address (address) > "Try to clean a single email ADDRESS for display. Return > @@ -278,8 +275,7 @@ message at DEPTH in the current thread." > " (" > date > ") (" > - (propertize (mapconcat 'identity tags " ") > - 'face 'notmuch-tag-face) > + (mapconcat 'identity tags " ") > ")\n") > (overlay-put (make-overlay start (point)) 'face 'notmuch-message-summary-face))) >