From: Austin Clements <amdragon@MIT.EDU>
To: David Edmondson <dme@dme.org>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH] Properly handle short writes in sigint handlers
Date: Sat, 24 Dec 2011 19:38:42 -0500 [thread overview]
Message-ID: <20111225003842.GA15906@mit.edu> (raw)
In-Reply-To: <cunhb0rvhc6.fsf@hotblack-desiato.hh.sledj.net>
Quoth David Edmondson on Dec 23 at 8:10 am:
> Sorry for being slow.
>
> Can you describe the situation in which you expect a write to stderr to
> be a short write? (Without error.)
If the PTY buffer is nearly full because, say, my terminal emulator is
a little behind or my SSH session is slow, I believe POSIX allows this
to be a short write (though Linux appears to treat PTYs like pipes and
will block rather than doing a short write, so it's completely
possible I'm misinterpreting POSIX).
> In that situation, what guarantee is there that the loop you've written
> will terminate?
There isn't, but for the same reason there's also no guarantee that a
single write will terminate.
> We're not talking about safeguarding a users' data here - this is a
> short message to indicate that a tool is terminating due to a signal.
> I'm concerned that the solution is worse than the problem.
As a user I'd be confused to see just part of the "Stopping" message
jammed in the middle of other output, but you're definitely right that
the consequences of this would not extend beyond a little bit of
harmless confusion.
next prev parent reply other threads:[~2011-12-25 0:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-21 21:38 [RFC][PATCH] notmuch: Workaround to allow ignoring non-void function return David Edmondson
2011-12-22 7:03 ` Austin Clements
2011-12-22 7:21 ` David Edmondson
2011-12-22 19:03 ` Austin Clements
2011-12-22 19:25 ` David Edmondson
2011-12-22 20:04 ` David Edmondson
2011-12-22 20:15 ` Austin Clements
2011-12-22 20:15 ` [PATCH] Properly handle short writes in sigint handlers Austin Clements
2011-12-23 8:10 ` David Edmondson
2011-12-23 12:30 ` Tomi Ollila
2011-12-25 0:38 ` Austin Clements
2011-12-25 0:38 ` Austin Clements [this message]
2011-12-23 19:10 ` Dmitry Kurochkin
2012-01-10 11:13 ` David Bremner
2012-01-11 13:04 ` Tomi Ollila
2011-12-22 9:32 ` [RFC][PATCH] notmuch: Workaround to allow ignoring non-void function return Dmitry Kurochkin
2011-12-22 11:24 ` David Edmondson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111225003842.GA15906@mit.edu \
--to=amdragon@mit.edu \
--cc=dme@dme.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).