From: Austin Clements <amdragon@MIT.EDU>
To: Jameson Graef Rollins <jrollins@finestructure.net>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH v4 2/4] Introduce a generic tree-like abstraction for MIME traversal.
Date: Sat, 24 Dec 2011 14:03:15 -0500 [thread overview]
Message-ID: <20111224190315.GE1927@mit.edu> (raw)
In-Reply-To: <87y5u2jte1.fsf@servo.finestructure.net>
Quoth Jameson Graef Rollins on Dec 23 at 11:55 pm:
> On Fri, 23 Dec 2011 22:45:46 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> > + /* True if decryption of this part was attempted. */
> > + notmuch_bool_t decrypt_attempted;
> > + /* True if decryption of this part's child succeeded. In this
> > + * case, the decrypted part is substituted for the second child of
> > + * this part (which would usually be the encrypted data). */
> > + notmuch_bool_t decrypt_success;
> > +
> > + /* True if signature verification on this part was attempted. */
> > + notmuch_bool_t sig_attempted;
>
> I think these new variables make sense, and reflect the correct
> semantics, as you already mentioned.
>
> I do, however, think the later variable should be called
> "verify_attempted" (or "verification_", or "ver_"?), instead of
> "sig_attempted", since verification is the complementary action on a
> signed part, just as decryption is for an encrypted one.
> "sig_attempted" somehow implies to me that one is trying to make a
> signature, not verify an existing one.
The intent was to parallel sig_validity, but I see your point. v5
with verify_attempted will be coming along soon (when our power comes
back).
next prev parent reply other threads:[~2011-12-24 19:02 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 2:21 [PATCH 0/4] First step of 'show' rewrite Austin Clements
2011-11-28 2:21 ` [PATCH 1/4] show: Pass notmuch_message_t instead of path to show_message_body Austin Clements
2011-11-28 2:21 ` [PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal Austin Clements
2011-11-29 19:11 ` Jani Nikula
2011-12-04 19:26 ` Austin Clements
2011-11-28 2:21 ` [PATCH 3/4] Utility function to seek in MIME trees in depth-first order Austin Clements
2011-11-28 2:21 ` [PATCH 4/4] show: Rewrite show_message_body to use the MIME tree interface Austin Clements
2011-11-28 19:44 ` Jani Nikula
2011-11-29 14:37 ` [PATCH 0/4] First step of 'show' rewrite Jameson Graef Rollins
2011-12-04 19:31 ` [PATCH v2 " Austin Clements
2011-12-04 19:31 ` [PATCH 1/4] show: Pass notmuch_message_t instead of path to show_message_body Austin Clements
2011-12-09 19:05 ` Dmitry Kurochkin
2011-12-09 19:54 ` Austin Clements
2011-12-09 19:59 ` Dmitry Kurochkin
2011-12-04 19:31 ` [PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal Austin Clements
2011-12-04 19:31 ` [PATCH 3/4] Utility function to seek in MIME trees in depth-first order Austin Clements
2011-12-04 19:31 ` [PATCH 4/4] show: Rewrite show_message_body to use the MIME tree interface Austin Clements
2011-12-09 17:39 ` [PATCH v2 0/4] First step of 'show' rewrite Austin Clements
2011-12-09 17:40 ` Dmitry Kurochkin
2011-12-09 17:51 ` Jameson Graef Rollins
2011-12-09 19:54 ` [PATCH v3 " Austin Clements
2011-12-09 19:54 ` [PATCH 1/4] show: Pass notmuch_message_t instead of path to show_message_body Austin Clements
2011-12-09 19:54 ` [PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal Austin Clements
2011-12-09 23:25 ` Dmitry Kurochkin
2011-12-10 21:17 ` Jameson Graef Rollins
2011-12-24 3:45 ` Austin Clements
2011-12-24 3:45 ` Austin Clements
2011-12-27 14:27 ` Daniel Kahn Gillmor
2011-12-28 3:23 ` Austin Clements
2011-12-10 21:19 ` Jameson Graef Rollins
2011-12-09 19:54 ` [PATCH 3/4] Utility function to seek in MIME trees in depth-first order Austin Clements
2011-12-10 11:43 ` Dmitry Kurochkin
2011-12-24 3:46 ` Austin Clements
2011-12-25 23:39 ` Dmitry Kurochkin
2011-12-09 19:54 ` [PATCH 4/4] show: Rewrite show_message_body to use the MIME tree interface Austin Clements
2011-12-11 10:34 ` Dmitry Kurochkin
2011-12-24 3:46 ` Austin Clements
2011-12-10 21:16 ` [PATCH v3 0/4] First step of 'show' rewrite Jameson Graef Rollins
2011-12-11 10:41 ` Dmitry Kurochkin
2011-12-15 11:03 ` David Bremner
2011-12-24 3:45 ` [PATCH v4 " Austin Clements
2011-12-24 3:45 ` [PATCH v4 1/4] show: Pass notmuch_message_t instead of path to show_message_body Austin Clements
2011-12-24 3:45 ` [PATCH v4 2/4] Introduce a generic tree-like abstraction for MIME traversal Austin Clements
2011-12-24 7:55 ` Jameson Graef Rollins
2011-12-24 8:05 ` Dmitry Kurochkin
2011-12-24 19:03 ` Austin Clements [this message]
2011-12-24 3:45 ` [PATCH v4 3/4] Utility function to seek in MIME trees in depth-first order Austin Clements
2011-12-24 3:45 ` [PATCH v4 4/4] show: Rewrite show_message_body to use the MIME tree interface Austin Clements
2011-12-24 3:58 ` [PATCH v4 0/4] First step of 'show' rewrite Dmitry Kurochkin
2011-12-24 7:55 ` Jameson Graef Rollins
2011-12-24 18:52 ` [PATCH v5 " Austin Clements
2011-12-24 18:52 ` [PATCH v5 1/4] show: Pass notmuch_message_t instead of path to show_message_body Austin Clements
2011-12-24 18:52 ` [PATCH v5 2/4] Introduce a generic tree-like abstraction for MIME traversal Austin Clements
2011-12-24 18:52 ` [PATCH v5 3/4] Utility function to seek in MIME trees in depth-first order Austin Clements
2011-12-24 18:52 ` [PATCH v5 4/4] show: Rewrite show_message_body to use the MIME tree interface Austin Clements
2011-12-25 23:35 ` [PATCH v5 0/4] First step of 'show' rewrite Dmitry Kurochkin
2011-12-26 2:42 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111224190315.GE1927@mit.edu \
--to=amdragon@mit.edu \
--cc=jrollins@finestructure.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).