From: Austin Clements <amdragon@MIT.EDU>
To: Jani Nikula <jani@nikula.org>,
Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: support "notmuch new" as a notmuch-poll-script
Date: Sun, 11 Dec 2011 17:58:22 -0500 [thread overview]
Message-ID: <20111211225822.GH2760@mit.edu> (raw)
In-Reply-To: <87wra26a5u.fsf@gmail.com>
Quoth Dmitry Kurochkin on Dec 12 at 2:00 am:
> Hi Jani.
>
> On Sun, 11 Dec 2011 23:48:20 +0200, Jani Nikula <jani@nikula.org> wrote:
> > Let notmuch-poll-script be a function as well as a string. Make default
> > value nil instead of an empty string, but allow "" for backwards
> > compatibility. Add a notmuch poll function to call "notmuch new" using the
> > configured notmuch-command.
> >
> > This allows taking better advantage of the "notmuch new" hooks from emacs
> > without intermediate scripts.
> >
>
> I was just thinking about working on this myself :)
>
> I think a better solution would be to allow running a command with
> arguments. Creating a elisp function just to run a command with some
> parameters feels wrong. This way we would have to add another function
> each time we want to add another argument.
This seems a little awkward to me, too, though perhaps it's the best
way. Other approaches to consider include accepting a list for
notmuch-poll-script (e.g., ("notmuch" "new")) or leaving it as a
string but treating it as a shell command so "notmuch new" would Just
Work. Personally, I think the latter is the most intuitive, but it
would be worth looking at how other customizable external commands are
done in Emacs.
A function seems powerful, but also like overkill. Can you give a use
case for a function that wouldn't be more easily solved by one of the
above approaches?
next prev parent reply other threads:[~2011-12-11 22:56 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-11 21:48 [PATCH] emacs: support "notmuch new" as a notmuch-poll-script Jani Nikula
2011-12-11 22:00 ` Dmitry Kurochkin
2011-12-11 22:19 ` Jani Nikula
2011-12-11 22:39 ` Dmitry Kurochkin
2011-12-11 22:58 ` Austin Clements [this message]
2011-12-11 23:10 ` Jani Nikula
2011-12-12 0:31 ` Austin Clements
2011-12-12 0:39 ` Dmitry Kurochkin
2011-12-12 10:15 ` Tomi Ollila
2011-12-12 10:21 ` Dmitry Kurochkin
2011-12-12 11:38 ` Tomi Ollila
2011-12-12 15:42 ` Austin Clements
2011-12-12 19:57 ` [PATCH v2] " Jani Nikula
2011-12-12 20:12 ` Dmitry Kurochkin
2011-12-12 20:24 ` Austin Clements
2011-12-12 20:50 ` [PATCH v3] " Jani Nikula
2011-12-12 20:53 ` Dmitry Kurochkin
2011-12-12 21:13 ` Jani Nikula
2011-12-12 21:24 ` Austin Clements
2011-12-12 21:34 ` Dmitry Kurochkin
2011-12-12 21:01 ` Austin Clements
2011-12-15 4:24 ` David Bremner
2012-01-12 17:31 ` Pieter Praet
2012-01-12 17:33 ` [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." Pieter Praet
2012-01-12 17:40 ` Dmitry Kurochkin
2012-01-12 22:10 ` Xavier Maillard
2012-01-13 8:23 ` David Edmondson
2012-01-13 12:42 ` Xavier Maillard
2012-01-13 12:37 ` Tomi Ollila
2012-01-13 13:01 ` David Edmondson
2012-01-14 9:14 ` Pieter Praet
2012-01-14 9:17 ` [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." Pieter Praet
2012-01-28 12:41 ` David Bremner
2012-01-28 12:55 ` Jani Nikula
2012-01-28 17:14 ` David Bremner
2012-01-30 9:23 ` David Edmondson
2012-02-01 13:46 ` Pieter Praet
2012-02-01 14:21 ` Dmitry Kurochkin
2012-01-30 7:03 ` Pieter Praet
2012-01-30 7:59 ` Tomi Ollila
2012-02-01 13:46 ` Pieter Praet
2012-01-31 3:34 ` David Bremner
2012-02-01 13:47 ` Pieter Praet
2012-02-01 13:50 ` [PATCH v2] " Pieter Praet
2012-02-01 14:05 ` David Edmondson
2012-02-02 1:31 ` David Bremner
2012-01-14 9:52 ` [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." Pieter Praet
2012-01-13 16:06 ` David Edmondson
2012-01-14 9:18 ` Pieter Praet
2012-01-15 11:55 ` David Edmondson
2012-01-16 10:56 ` [PATCH v2] " Pieter Praet
2012-01-16 11:06 ` David Edmondson
2012-01-16 12:39 ` Tomi Ollila
2012-01-21 12:21 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111211225822.GH2760@mit.edu \
--to=amdragon@mit.edu \
--cc=dmitry.kurochkin@gmail.com \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).