From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 57EED429E21 for ; Mon, 3 Oct 2011 22:00:57 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ObkvdijT4pP8 for ; Mon, 3 Oct 2011 22:00:55 -0700 (PDT) Received: from mail-bw0-f53.google.com (mail-bw0-f53.google.com [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 44DDF431FB6 for ; Mon, 3 Oct 2011 22:00:55 -0700 (PDT) Received: by bkbzt12 with SMTP id zt12so219887bkb.26 for ; Mon, 03 Oct 2011 22:00:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-type:content-disposition:in-reply-to :organization:user-agent; bh=Ar2oebMp8BGgQJh0R+0EHLbZRtU/g1EFG+n287Ciolg=; b=wrLrRiQlfuJx5IX8E7J+h8Y+qynpgYqZO6tmgXSeuRjG3l5r+asQ6O/kORFP/vFpjr wRXB2A+N93E081hVA+pOT9vIs9itnKqPbGpcD7cdSJ7hlMIgsEdPYtRf8FYDBaABYNxT M/1mSfrb3Oc7N94gUKgih+p1A8ilmjpgxh6E4= Received: by 10.223.56.67 with SMTP id x3mr1110418fag.64.1317704452312; Mon, 03 Oct 2011 22:00:52 -0700 (PDT) Received: from localhost ([88.236.39.101]) by mx.google.com with ESMTPS id m26sm23996273fac.6.2011.10.03.22.00.50 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 03 Oct 2011 22:00:51 -0700 (PDT) Date: Tue, 4 Oct 2011 08:00:46 +0300 From: Ali Polatel To: David Bremner Subject: Re: [PATCH] lib: make find_message{,by_filename) report errors Message-ID: <20111004050046.GA6048@hayalet> Mail-Followup-To: David Bremner , Austin Clements , Notmuch Mailing List References: <20110930064712.GA30012@hayalet> <8739f9muhp.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="opJtzjQTFsWo+cga" Content-Disposition: inline In-Reply-To: <8739f9muhp.fsf@zancas.localnet> Organization: Pink Floyd User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Notmuch Mailing List , Austin Clements X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Oct 2011 05:00:57 -0000 --opJtzjQTFsWo+cga Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable David Bremner yazm=C4=B1=C5=9F: >On Sat, 1 Oct 2011 11:12:23 +0300, Ali Polatel wrote: >> From: Ali Polatel >> >> Looks like the patch did not make it correctly the first time. >> Resending using git-send-email=E2=84=A2 >> >> You may also find the commit in my notmuch repository: >> git://github.com/alip/notmuch.git branch: find_message > > >Hi Ali; > >Thanks for reworking this patch. I looked at branch find_message-v2 >in your repo. I have a few comments. Thanks for going over the patch, expect a new set of patches soon! >- In the comments for _resolve_message_id_to_thread_id I guess thread_id > should be thread_id_ret? Fixed. >- in notmuch_database_find_message_by_file_name, I'm not sure why you > set status to NOTMUCH_STATUS_OUT_OF_MEMORY in the catch block. Is this > a typo? Looks like a copy & paste error. I must have blindly copied the error =66rom the previous block. Fixed. >- after the DONE: label of the same routine, how is *message_ret destroyed? > does it need to wait until the talloc context "notmuch" is freed? Yes, I have modified it to call notmuch_message_destroy() in case '*message_ret' is non-NULL after the DONE: >- I don't really get the change of user to caller around notmuch.h:286 > It is not a big deal, but I guess we should try to be consistent. I don't get what you mean by consistency here but this hunk is unrelated to the problem which the patch is trying to address. Reverted. >David > > -alip --opJtzjQTFsWo+cga Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (GNU/Linux) iEYEARECAAYFAk6Kkv4ACgkQQU4yORhF8iBInwCgpop38ePUu3GYNOvodxl1vXZ6 u7EAn0lJf4uTgDGLVa0oi0R/003RSm21 =Zjxr -----END PGP SIGNATURE----- --opJtzjQTFsWo+cga--