From: Ali Polatel <polatel@gmail.com>
To: David Bremner <david@tethera.net>
Cc: Notmuch Mailing List <notmuch@notmuchmail.org>,
Austin Clements <amdragon@MIT.EDU>
Subject: Re: [PATCH] lib: make find_message{,by_filename) report errors
Date: Tue, 4 Oct 2011 08:00:46 +0300 [thread overview]
Message-ID: <20111004050046.GA6048@hayalet> (raw)
In-Reply-To: <8739f9muhp.fsf@zancas.localnet>
[-- Attachment #1: Type: text/plain, Size: 1538 bytes --]
David Bremner yazmış:
>On Sat, 1 Oct 2011 11:12:23 +0300, Ali Polatel <polatel@gmail.com> wrote:
>> From: Ali Polatel <alip@exherbo.org>
>>
>> Looks like the patch did not make it correctly the first time.
>> Resending using git-send-email™
>>
>> You may also find the commit in my notmuch repository:
>> git://github.com/alip/notmuch.git branch: find_message
>
>
>Hi Ali;
>
>Thanks for reworking this patch. I looked at branch find_message-v2
>in your repo. I have a few comments.
Thanks for going over the patch, expect a new set of patches soon!
>- In the comments for _resolve_message_id_to_thread_id I guess thread_id
> should be thread_id_ret?
Fixed.
>- in notmuch_database_find_message_by_file_name, I'm not sure why you
> set status to NOTMUCH_STATUS_OUT_OF_MEMORY in the catch block. Is this
> a typo?
Looks like a copy & paste error. I must have blindly copied the error
from the previous block. Fixed.
>- after the DONE: label of the same routine, how is *message_ret destroyed?
> does it need to wait until the talloc context "notmuch" is freed?
Yes, I have modified it to call notmuch_message_destroy() in case
'*message_ret' is non-NULL after the DONE:
>- I don't really get the change of user to caller around notmuch.h:286
> It is not a big deal, but I guess we should try to be consistent.
I don't get what you mean by consistency here but this hunk is unrelated
to the problem which the patch is trying to address.
Reverted.
>David
>
>
-alip
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2011-10-04 5:00 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-27 13:25 Concerns regarding some library functions Ali Polatel
2011-09-27 16:59 ` David Bremner
2011-09-27 22:46 ` Austin Clements
2011-09-28 7:53 ` Ali Polatel
2011-09-29 14:51 ` Austin Clements
2011-09-29 19:59 ` David Bremner
2011-09-29 20:15 ` Austin Clements
2011-10-04 11:18 ` David Bremner
2011-10-04 13:40 ` Tomi Ollila
2011-10-04 19:36 ` libnotmuch SONAME bumped David Bremner
2011-09-30 6:47 ` Concerns regarding some library functions Ali Polatel
2011-10-01 8:12 ` [PATCH] lib: make find_message{,by_filename) report errors Ali Polatel
2011-10-01 8:12 ` Ali Polatel
2011-10-05 13:42 ` Sebastian Spaeth
2011-10-03 16:49 ` [PATCH v1 0/1] " Ali Polatel
2011-10-03 16:49 ` [PATCH v1 1/1] " Ali Polatel
2011-10-03 17:43 ` Austin Clements
2011-10-03 20:38 ` [PATCH v1 1/1] lib: make find_message{, by_filename) " Ali Polatel
2011-10-03 20:40 ` [PATCH v2 0/2] Better error handling Ali Polatel
2011-10-03 20:40 ` [PATCH v2 1/2] lib: destroy message object after message removal Ali Polatel
2011-10-03 20:40 ` [PATCH v2 2/2] lib: make find_message{,by_filename) report errors Ali Polatel
2011-10-03 20:53 ` [PATCH v2 0/2] Better error handling Ali Polatel
2011-10-03 21:03 ` Austin Clements
2011-10-04 1:10 ` [PATCH] lib: make find_message{,by_filename) report errors David Bremner
2011-10-04 5:00 ` Ali Polatel [this message]
2011-10-04 5:06 ` [PATCH v3 0/2] Better error handling Ali Polatel
2011-10-04 5:06 ` [PATCH v3 1/2] lib: destroy message object after message removal Ali Polatel
2011-10-04 5:06 ` [PATCH v3 2/2] lib: make find_message{,by_filename) report errors Ali Polatel
2011-10-04 10:43 ` [PATCH v3 0/2] Better error handling David Bremner
2011-09-28 15:42 ` Concerns regarding some library functions Sebastian Spaeth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111004050046.GA6048@hayalet \
--to=polatel@gmail.com \
--cc=amdragon@MIT.EDU \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).